Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): ensure that a declaration is available in type-to-value conversion #38684

Closed
wants to merge 1 commit into from

Commits on Sep 2, 2020

  1. fix(compiler-cli): ensure that a declaration is available in type-to-…

    …value conversion
    
    The type-to-value conversion could previously crash if a symbol was
    resolved that does not have any declarations, e.g. because it's imported
    from a missing module. This would typically result in a semantic
    TypeScript diagnostic and halt further compilation, therefore not
    reaching the type-to-value conversion logic. In Bazel however, it turns
    out that Angular semantic diagnostics are requested even if there are
    semantic TypeScript errors in the program, so it would then reach the
    type-to-value conversation and crash.
    
    This commit fixes the unsafe access and adds a test that ignores the
    TypeScript semantic error, effectively replicating the situation as
    experienced under Bazel.
    
    Fixes angular#38670
    JoostK committed Sep 2, 2020
    Copy the full SHA
    a361cde View commit details
    Browse the repository at this point in the history