Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): clear the RefreshTransplantedView when detached #38768

Closed
wants to merge 1 commit into from

Commits on Sep 9, 2020

  1. fix(core): clear the RefreshTransplantedView when detached

    The `RefreshTransplantedView` flag is used to indicate that the view or one of its children
    is transplanted and dirty, so it should still be refreshed as part of change detection.
    This flag is set on the transplanted view itself as well setting a
    counter on as its parents.
    When a transplanted view is detached and still has this flag, it means
    it got detached before it was refreshed. This can happen for "backwards
    references" or transplanted views that are inserted at a location that
    was already checked. In this case, we should decrement the parent
    counters _and_ clear the flag on the detached view so it's not seen as
    "transplanted" anymore (it is detached and has no parent counters to
    adjust).
    
    fixes angular#38619
    atscott committed Sep 9, 2020
    Copy the full SHA
    dc14f57 View commit details
    Browse the repository at this point in the history