Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(router): Add test for canLoad prioritized evaluation #38781

Closed
wants to merge 1 commit into from
Closed

test(router): Add test for canLoad prioritized evaluation #38781

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Sep 9, 2020

This change contains the test from #38780. The fix from that PR (using concatMap) is already present in master.

@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: major This PR is targeted for the next major release labels Sep 9, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 9, 2020
AndrewKushnir
AndrewKushnir approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Quick note: it looks like the change was made to the apply_redirects.ts files as well, so may be it'd make sense to change commit message to fix(router) ...?

@atscott
Copy link
Contributor Author

atscott commented Sep 9, 2020

LGTM 👍

Quick note: it looks like the change was made to the apply_redirects.ts files as well, so may be it'd make sense to change commit message to fix(router) ...?

@AndrewKushnir - The change to apply_redirects actually doesn't change how anything functions. I'll change the commit message to refactor though!

@atscott
refactor(router): Remove defer as it's not needed anymore
c8167d1 
This change contains the test from angular#38780 and also removes `defer` from
the `apply_redirects` logic because the change that introduced
`concatMap` instead of `map`...`concatAll` makes `defer` unnecessary.
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 9, 2020
@atscott
Copy link
Contributor Author

atscott commented Sep 10, 2020

presubmit

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @AndrewKushnir @googlebot