Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localize): ensure that formatOptions is optional #38787

Closed
wants to merge 1 commit into from
Closed

fix(localize): ensure that formatOptions is optional #38787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/localize/src/tools/src/extract/main.ts
View file
Open in desktop
Expand Up @@ -208,7 +208,7 @@ export function extractTranslations({

export function getSerializer(
format: string, sourceLocale: string, rootPath: AbsoluteFsPath, useLegacyIds: boolean,
formatOptions: FormatOptions): TranslationSerializer {
formatOptions: FormatOptions = {}): TranslationSerializer {
switch (format) {
case 'xlf':
case 'xlif':
Expand Down
2 changes: 1 addition & 1 deletion packages/localize/src/tools/src/extract/translation_files/xliff1_translation_serializer.ts
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ const LEGACY_XLIFF_MESSAGE_LENGTH = 40;
export class Xliff1TranslationSerializer implements TranslationSerializer {
constructor(
private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean,
private formatOptions: FormatOptions) {
private formatOptions: FormatOptions = {}) {
validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/localize/src/tools/src/extract/translation_files/xliff2_translation_serializer.ts
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ export class Xliff2TranslationSerializer implements TranslationSerializer {
private currentPlaceholderId = 0;
constructor(
private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean,
private formatOptions: FormatOptions) {
private formatOptions: FormatOptions = {}) {
validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions);
}

Expand Down