Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): detect pipes in ICUs in template binder #38810

Closed
wants to merge 1 commit into from
Closed

fix(compiler): detect pipes in ICUs in template binder #38810

wants to merge 1 commit into from

Commits on Sep 11, 2020

  1. fix(compiler): detect pipes in ICUs in template binder 

    Recent work on compiler internals in angular#38539 led to an unexpected failure,
where a pipe used exclusively inside of an ICU would no longer be
emitted into the compilation output. This caused runtime errors due to
missing pipes.

The issue occurred because the change in angular#38539 would determine the set
of used pipes up-front, independent from the template compilation using
the `R3TargetBinder`. However, `R3TargetBinder` did not consider
expressions within ICUs, so any pipe usages within those expressions
would not be detected. This fix unblocks angular#38539 and also concerns
upcoming linker work, given that prelink compilations would not go
through full template compilation but only `R3TargetBinder`.
    @JoostK
    JoostK committed Sep 11, 2020
    Copy the full SHA
    0fd8ae3 View commit details
    Browse the repository at this point in the history