Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(service-worker): update SW guide to include changes about cache (#43163) #43375

Closed
wants to merge 1 commit into from
Closed

Conversation

naveedahmed1
Copy link
Contributor

@naveedahmed1 naveedahmed1 commented Sep 7, 2021

Update Safety Worker section in Service Worker guide and mention that safety worker also removes the SW caches.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Safety worker now also removes the SW caches, this wasn't mentioned in docs

Issue Number: #43163

What is the new behavior?

Update docs to mention that safety worker also removes the SW caches.

Does this PR introduce a breaking change?

  • Yes
  • No

…removal

update safety worker section in service worker guide and mention that safety worker also removes the SW caches
@google-cla google-cla bot added the cla: yes label Sep 7, 2021
@pullapprove pullapprove bot requested a review from alxhub September 7, 2021 16:36
@gkalpak
Copy link
Member

gkalpak commented Sep 7, 2021

Thx, @naveedahmed1 👍
Can you please incorporate the changes into #43324?

@gkalpak gkalpak closed this Sep 7, 2021
@naveedahmed1
Copy link
Contributor Author

@gkalpak I have added these changes to #43324 I hope I have done it correctly.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants