Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): update Angular framework/Material to versions 13.0.0-next.9/7 #43686

Closed
wants to merge 6 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 2, 2021

See individual commits for details.

This is the equivalent of #43687, but for the master branch.

Fixes #28114.

@gkalpak gkalpak added state: WIP area: build & ci Related the build and CI infrastructure of the project refactoring Issue that involves refactoring or code-cleanup comp: docs-infra target: major This PR is targeted for the next major release labels Oct 2, 2021
@gkalpak gkalpak added this to the docs-infra-aio-app milestone Oct 2, 2021
@google-cla google-cla bot added the cla: yes label Oct 2, 2021
@gkalpak gkalpak changed the title Build aio update angular build(docs-infra): update Angular framework and Material to latest prerelease versions (v13.0.0-next.10/7) Oct 2, 2021
@gkalpak gkalpak changed the title build(docs-infra): update Angular framework and Material to latest prerelease versions (v13.0.0-next.10/7) build(docs-infra): update Angular framework/Material to versions 13.0.0-next.10/7 Oct 2, 2021
@mary-poppins
Copy link

You can preview 8c90794 at https://pr43686-8c90794.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4b22c3b at https://pr43686-4b22c3b.ngbuilds.io/.

@gkalpak gkalpak changed the title build(docs-infra): update Angular framework/Material to versions 13.0.0-next.10/7 build(docs-infra): update Angular framework/Material to versions 13.0.0-next.9/7 Oct 2, 2021
@gkalpak gkalpak added this to IN PROGRESS in docs-infra Oct 2, 2021
@mary-poppins
Copy link

You can preview 2a9f6a7 at https://pr43686-2a9f6a7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview fcfb4d1 at https://pr43686-fcfb4d1.ngbuilds.io/.

@crisbeto
Copy link
Member

crisbeto commented Oct 2, 2021

FYI I did the Angular and TS upgrades already in #43642.

@mary-poppins
Copy link

You can preview 3f7abe9 at https://pr43686-3f7abe9.ngbuilds.io/.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Oct 3, 2021
@gkalpak
Copy link
Member Author

gkalpak commented Oct 3, 2021

Thx for the heads-up, @crisbeto. I'll rebase this PR if yours gets merged first.
(For now, I am keeping the changes here as well in case this gets merged before your PR, because we want to get the updates deployed to angular.io asap.)

@gkalpak gkalpak marked this pull request as ready for review October 3, 2021 06:18
@gkalpak gkalpak moved this from IN PROGRESS to REVIEW in docs-infra Oct 3, 2021
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2021
@ngbot

This comment has been minimized.

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 5, 2021
@mary-poppins
Copy link

You can preview 31471eb at https://pr43686-31471eb.ngbuilds.io/.

@gkalpak
Copy link
Member Author

gkalpak commented Oct 5, 2021

The CI failures are not related to this PR and will be fixed by #43714.

@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 5, 2021
@mary-poppins
Copy link

You can preview baaf1c6 at https://pr43686-baaf1c6.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Oct 5, 2021
…ovide intellisense

Add an appropriate `$schema` property in `ngsw-config.template.json` to
allow IDEs to provide intellisense about the various fields of the
config.
Prefix error messages with the Angular version currently used in the
angular.io app. This applies to both errors logged to the console and
reported to Google Analytics and makes debugging certain errors easier.
This commit updates angular.io to more closely align with new apps
created with the latest Angular CLI and remove redundant files/config
now that CLI has dropped support for differential loading.
This commit updates angular.io to the latest prerelease version of
Angular CDK/Material (v13.0.0-next.7).
…ministic

As explained in angular#43679, currently the generation of the `ngsw.json` SW
manifest is non-deterministic and often incorrect. Until we can update
to an `@angular/service-worker` version that includes the fix from
PR angular#43679, we temporarily work-around the issue by re-generating the
`ngsw.json` manifest after `ng build` using the `ngsw-config` binary
exposed by `@angular/service-worker`.

NOTE:
This works around the issue, because the [FileSystem][1] class used by
the `ngsw-config` binary happens to be synchronous (unlike the
implementation provided by the Angular CLI), thus avoiding the race
conditions described in angular#43679.

[1]: https://github.com/angular/angular/blob/c721135e370b34c840756bcfb22c8119b4c8c452/packages/service-worker/cli/filesystem.ts#L15
@mary-poppins
Copy link

You can preview b80b42a at https://pr43686-b80b42a.ngbuilds.io/.

@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2021
@dylhunn
Copy link
Contributor

dylhunn commented Oct 6, 2021

This PR was merged into the repository by commit 841c5ae.

@dylhunn dylhunn closed this in 72d1dfd Oct 6, 2021
dylhunn pushed a commit that referenced this pull request Oct 6, 2021
…#43686)

Prefix error messages with the Angular version currently used in the
angular.io app. This applies to both errors logged to the console and
reported to Google Analytics and makes debugging certain errors easier.

PR Close #43686
dylhunn pushed a commit that referenced this pull request Oct 6, 2021
…ps (#43686)

This commit updates angular.io to more closely align with new apps
created with the latest Angular CLI and remove redundant files/config
now that CLI has dropped support for differential loading.

PR Close #43686
dylhunn pushed a commit that referenced this pull request Oct 6, 2021
…43686)

This commit updates angular.io to the latest prerelease version of
Angular CDK/Material (v13.0.0-next.7).

PR Close #43686
dylhunn pushed a commit that referenced this pull request Oct 6, 2021
…ministic (#43686)

As explained in #43679, currently the generation of the `ngsw.json` SW
manifest is non-deterministic and often incorrect. Until we can update
to an `@angular/service-worker` version that includes the fix from
PR #43679, we temporarily work-around the issue by re-generating the
`ngsw.json` manifest after `ng build` using the `ngsw-config` binary
exposed by `@angular/service-worker`.

NOTE:
This works around the issue, because the [FileSystem][1] class used by
the `ngsw-config` binary happens to be synchronous (unlike the
implementation provided by the Angular CLI), thus avoiding the race
conditions described in #43679.

[1]: https://github.com/angular/angular/blob/c721135e370b34c840756bcfb22c8119b4c8c452/packages/service-worker/cli/filesystem.ts#L15

PR Close #43686
@gkalpak gkalpak deleted the build-aio-update-angular branch October 6, 2021 17:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
Development

Successfully merging this pull request may close these issues.

angular.io app gets stuck in “loading document” state, likely due to client-server version skew
6 participants