perf(core): make IterableDiffers and KeyValueDiffers tree-shakable
#45094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
state: WIP
area: core
This commit removed references to the `IterableDiffers` and `KeyValueDiffers` classes from the `ApplicationModule`, which effectively make them tree-shakable. Both classes have `prov` static field with the right setup, so they'll be properly initialized when referenced.
AndrewKushnir
force-pushed
the
iterable-differs-tree-shake
branch
from
41a4f7b
to
9f6bcc7
Compare
AndrewKushnir
added
action: review
jessicajaniuk
approved these changes
Feb 15, 2022
atscott
reviewed
Feb 15, 2022
| @@ -3,7 +3,7 @@ | |||
| "master": { | |||
| "uncompressed": { | |||
| "runtime": 1083, | |||
| "main": 139416, | |||
| "main": 127944, | |||
atscott
approved these changes
Feb 15, 2022
dylhunn
approved these changes
Feb 16, 2022
3 tasks
jessicajaniuk
added
action: merge
jessicajaniuk
added
action: review
alxhub
added
target: minor
|
Note: conflicts with 13.2.x. |
|
This PR was merged into the repository by commit 45d98e7. |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Feb 16, 2022
angular#45094) This commit removed references to the `IterableDiffers` and `KeyValueDiffers` classes from the `ApplicationModule`, which effectively make them tree-shakable. Both classes have `prov` static field with the right setup, so they'll be properly initialized when referenced. PR Close angular#45094
alxhub
pushed a commit
that referenced
this pull request
Feb 18, 2022
#45094) (#45115) This commit removed references to the `IterableDiffers` and `KeyValueDiffers` classes from the `ApplicationModule`, which effectively make them tree-shakable. Both classes have `prov` static field with the right setup, so they'll be properly initialized when referenced. PR Close #45094 PR Close #45115
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 8, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.3/13.2.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.3/13.2.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.3/13.2.4) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.3/13.2.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.3/13.2.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.3/13.2.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.3/13.2.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.3/13.2.4) | | [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.3/13.2.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.2.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1324-2022-02-23) [Compare Source](angular/angular@13.2.3...13.2.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [1a4b489692](angular/angular@1a4b489) | perf | improve algorithm to balance animation namespaces ([#​45113](angular/angular#45113)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [cbd23ee0de](angular/angular@cbd23ee) | perf | make `IterableDiffers` and `KeyValueDiffers` tree-shakable ([#​45094](angular/angular#45094)) ([#​45115](angular/angular#45115)) | #### Special Thanks Alan Cohen, AlirezaEbrahimkhani, Andrew Kushnir, Daniele Maltese, David Wolf, JoostK, Paul Gschwendtner, dario-piotrowicz and manuelkroiss <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1189 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
angular#45094) This commit removed references to the `IterableDiffers` and `KeyValueDiffers` classes from the `ApplicationModule`, which effectively make them tree-shakable. Both classes have `prov` static field with the right setup, so they'll be properly initialized when referenced. PR Close angular#45094
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removed references to the
IterableDiffersandKeyValueDiffersclasses from theApplicationModule, which effectively make them tree-shakable. Both classes haveprovstatic field with the right setup, so they'll be properly initialized when referenced.Note: there are other providers from the
ApplicationModulethat we can make tree-shakable and I'll create followup PR(s) to take care of that incrementally.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?