New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): improve error message for invalid value accessors #45192
fix(forms): improve error message for invalid value accessors #45192
Conversation
7e15ca1
to
c104e66
Compare
improve error message for invalid value accessors when accessor is not provided as array
65ed10d
to
158a7d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ameryousuf thanks for applying additional changes 👍
The changes look good, I'll run tests in Google's codebase and let you know if there are any specific use-cases that we should address in this PR.
Thank you.
Presubmit (internal-only link). |
Merge-assistance: the change was reviewed and approved, but Dylan is OOO, so I can't get this PR to the "green" state. The PR is ready for merge. |
This PR was merged into the repository by commit 9db9091. |
improve error message for invalid value accessors when accessor is not provided as array PR Close #45192
improve error message for invalid value accessors when accessor is not provided as array PR Close #45192
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.6/13.3.0) | | [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.6/13.3.0) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.6/13.3.0) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.6/13.3.0) | | [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.6/13.3.0) | | [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.6/13.3.0) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.6/13.3.0) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.6/13.3.0) | | [@angular/router](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.6/13.3.0) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.3.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1330-rc0-2022-03-16) [Compare Source](angular/angular@13.2.7...13.3.0) ##### core | Commit | Type | Description | | -- | -- | -- | | [b5bb614c74](angular/angular@61a316c) | feat | support TypeScript 4.6 ([#​45190](angular/angular#45190)) | #### Special Thanks Alistair Kane, Andrew Scott and Kristiyan Kostadinov <!-- CHANGELOG SPLIT MARKER --> ### [`v13.2.7`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1327-2022-03-16) [Compare Source](angular/angular@13.2.6...13.2.7) ##### forms | Commit | Type | Description | | -- | -- | -- | | [eac94f0945](angular/angular@eac94f0) | fix | improve error message for invalid value accessors ([#​45192](angular/angular#45192)) | #### Special Thanks Alistair Kane, Amer Yousuf, Andrew Scott, Jessica Janiuk, Lee Cooper, alirezaghey and why520crazy <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1227 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
…r#45192) improve error message for invalid value accessors when accessor is not provided as array PR Close angular#45192
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #44486
What is the new behavior?
Does this PR introduce a breaking change?
Other information