feat(router): make RouterOutlet name an Input so it can be set dynami… #46569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
action: global presubmit
|
Since this does change the timing of the outlet getting activated, it might be considered breaking. Started a TGP run to see what, if anything, fails. |
atscott
force-pushed
the
routeroutletnameinput
branch
from
9126d00
to
125ed08
Compare
atscott
added
breaking changes
target: major
atscott
force-pushed
the
routeroutletnameinput
branch
from
125ed08
to
d80f6df
Compare
atscott
force-pushed
the
routeroutletnameinput
branch
from
d80f6df
to
3859f79
Compare
atscott
force-pushed
the
routeroutletnameinput
branch
from
3859f79
to
a2384ba
Compare
pullapprove
bot
requested review from
alxhub,
AndrewKushnir and
pkozlowski-opensource
AndrewKushnir
approved these changes
Sep 19, 2022
AndrewKushnir
approved these changes
Sep 19, 2022
atscott
force-pushed
the
routeroutletnameinput
branch
4 times, most recently
from
1b45aeb
to
1471326
Compare
…cally This commit updates the 'name' of `RouterOutlet` to be an `Input` rather than an attribute. Note that this change does not affect `[attr.name]=` because those already would not have worked. The static name was only read in the constructor and if it wasn't available, it would use 'PRIMARY' instead. fixes angular#12522 BREAKING CHANGE: Previously, the `RouterOutlet` would immediately instantiate the component being activated during navigation. Now the component is not instantiated until the change detection runs. This could affect tests which do not trigger change detection after a router navigation. In rarer cases, this can affect production code that relies on the exact timing of component availability.
atscott
force-pushed
the
routeroutletnameinput
branch
from
1471326
to
e65047f
Compare
pkozlowski-opensource
approved these changes
Sep 23, 2022
atscott
added
action: merge
|
Merge assistance: Please merge and sync on its own. This will also require patching this CL during the sync. |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
TGP. |
|
@atscott it looks like there are a couple of regressions, see TGP results. Could you please take a look when you get a chance? Adding a "blocked" label for now... |
|
The latest TGP is "green", we can proceed with merging this PR. |
|
This PR was merged into the repository by commit c3f8579. |
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
…cally (angular#46569) This commit updates the 'name' of `RouterOutlet` to be an `Input` rather than an attribute. Note that this change does not affect `[attr.name]=` because those already would not have worked. The static name was only read in the constructor and if it wasn't available, it would use 'PRIMARY' instead. fixes angular#12522 BREAKING CHANGE: Previously, the `RouterOutlet` would immediately instantiate the component being activated during navigation. Now the component is not instantiated until the change detection runs. This could affect tests which do not trigger change detection after a router navigation. In rarer cases, this can affect production code that relies on the exact timing of component availability. PR Close angular#46569
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
…cally (angular#46569) This commit updates the 'name' of `RouterOutlet` to be an `Input` rather than an attribute. Note that this change does not affect `[attr.name]=` because those already would not have worked. The static name was only read in the constructor and if it wasn't available, it would use 'PRIMARY' instead. fixes angular#12522 BREAKING CHANGE: Previously, the `RouterOutlet` would immediately instantiate the component being activated during navigation. Now the component is not instantiated until the change detection runs. This could affect tests which do not trigger change detection after a router navigation. In rarer cases, this can affect production code that relies on the exact timing of component availability. PR Close angular#46569
mprobst
pushed a commit
to mprobst/angular
that referenced
this pull request
Oct 5, 2022
…cally (angular#46569) This commit updates the 'name' of `RouterOutlet` to be an `Input` rather than an attribute. Note that this change does not affect `[attr.name]=` because those already would not have worked. The static name was only read in the constructor and if it wasn't available, it would use 'PRIMARY' instead. fixes angular#12522 BREAKING CHANGE: Previously, the `RouterOutlet` would immediately instantiate the component being activated during navigation. Now the component is not instantiated until the change detection runs. This could affect tests which do not trigger change detection after a router navigation. In rarer cases, this can affect production code that relies on the exact timing of component availability. PR Close angular#46569
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cally
This commit updates the 'name' of
RouterOutletto be anInputratherthan an attribute. Note that this change does not affect
[attr.name]=because those already would not have worked. The static name was only
read in the constructor and if it wasn't available, it would use
'PRIMARY' instead.
fixes #12522