feat(core): add createComponent and reflectComponentType functions
#46685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
feature
|
This is great replacement for component factories! |
AndrewKushnir
force-pushed
the
create-component-ref
branch
2 times, most recently
from
460d222
to
274f4a3
Compare
AndrewKushnir
added
action: review
AndrewKushnir
requested review from
alxhub,
pkozlowski-opensource and
atscott
and removed request for
alxhub
AndrewKushnir
changed the title
createComponentRef and createComponentMirror functionscreateComponentRef and reflectComponentType functions
|
@gund thanks for the feedback. We discussed this question with the team further and decided to rename the function to |
pkozlowski-opensource
requested changes
Jul 8, 2022
There was a problem hiding this comment.
LGTM overall but I would like to discuss the API surface, see https://github.com/angular/angular/pull/46685/files#r916504416
atscott
approved these changes
Jul 8, 2022
AndrewKushnir
removed
the
action: review
alxhub
reviewed
Jul 13, 2022
AndrewKushnir
force-pushed
the
create-component-ref
branch
from
f1af445
to
5a47792
Compare
|
@alxhub thanks for the review, the comments are now addressed. Could you please take a final look at the public API when you get a chance? Thank you. |
|
You can preview 5a47792 at https://pr46685-5a47792.ngbuilds.io/. |
alxhub
reviewed
Jul 14, 2022
This commit introduces a new function that allows creating a `ComponentRef` instance based on provided Component and a set of options. The function can be used to cover a number of use-cases where the `ComponentFactory` symbol was used previously. Closes angular#45263.
This commit introduces a new function that allows creating a object which exposes a number of getters to retrieve information about a given component. Closes angular#44926.
This commit refactors the code to move some functions around to avoid circular dependencies in TS imports. The newly added functions are now located in the `packages/core/src/render3/component.ts` file (instead of `packages/core/src/render3/component_ref.ts`), which is a better place for them anyway.
This commit updates the `inputs` and `outputs` objects of the `ComponentMirror` to mark their properties as readonly.
AndrewKushnir
force-pushed
the
create-component-ref
branch
from
5a47792
to
cb82edc
Compare
AndrewKushnir
added
action: merge
|
You can preview cb82edc at https://pr46685-cb82edc.ngbuilds.io/. |
|
This PR was merged into the repository by commit 4a81fe7. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jul 14, 2022
This commit refactors the code to move some functions around to avoid circular dependencies in TS imports. The newly added functions are now located in the `packages/core/src/render3/component.ts` file (instead of `packages/core/src/render3/component_ref.ts`), which is a better place for them anyway. PR Close #46685
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Jul 15, 2022
This commit introduces a new function that allows creating a `ComponentRef` instance based on provided Component and a set of options. The function can be used to cover a number of use-cases where the `ComponentFactory` symbol was used previously. Closes angular#45263. PR Close angular#46685
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Jul 15, 2022
This commit introduces a new function that allows creating a object which exposes a number of getters to retrieve information about a given component. Closes angular#44926. PR Close angular#46685
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Jul 15, 2022
…#46685) This commit refactors the code to move some functions around to avoid circular dependencies in TS imports. The newly added functions are now located in the `packages/core/src/render3/component.ts` file (instead of `packages/core/src/render3/component_ref.ts`), which is a better place for them anyway. PR Close angular#46685
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Jul 15, 2022
…ngular#46685) This commit updates the `inputs` and `outputs` objects of the `ComponentMirror` to mark their properties as readonly. PR Close angular#46685
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Resolves #45263 and #44926.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?