refactor(router): Update Router to be providedIn: 'root' #46824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
state: blocked
target: minor
atscott
force-pushed
the
routerForRoot
branch
6 times, most recently
from
235faaf
to
4161b06
Compare
atscott
added
target: rc
pkozlowski-opensource
approved these changes
Jul 19, 2022
AndrewKushnir
approved these changes
Jul 20, 2022
AndrewKushnir
approved these changes
Jul 20, 2022
This commit updates the Router itself to be `providedIn: 'root'` with a factory function rather than provided in the `RouterModule`.
atscott
removed
the
target: rc
atscott
added
target: patch
AndrewKushnir
added
target: minor
|
This PR was merged into the repository by commit d583f85. |
|
@atscott there was a merge conflict with the 14.1.0 branch, so this PR was merged into the main branch only. Could you please create a new PR and target the 14.1.0 branch if the change should be included there as well? Thank you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Router itself to be
providedIn: 'root'with afactory function rather than provided in the
RouterModule.Note: includes commit from #46758 which should be submitted first.