New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): expose resolved route title #46826
Conversation
93e1afa
to
5b71be0
Compare
23f4358
to
4c6fc59
Compare
4c6fc59
to
aa9153e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the changes. Before we merge, could you please squash the commits into one?
aa9153e
to
5522583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
5522583
to
0b237c0
Compare
Expose resolved route title from ActivatedRoute and ActivatedRouteSnapshot
0b237c0
to
0a79dea
Compare
caretaker note: This will require patching cl/462221001 when syncing. |
green TGP with patches |
merge assistance:
|
This PR was merged into the repository by commit 10289f1. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #46825
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #46825
What is the new behavior?
Since Angular 14, router has a new mechanism to update page title from route config. The route can either be a static string or resolved in the same way as
resolve
data.But the resolved route title is not exposed and inaccessible from client application (it seems the title is actually stored in the resolved
Data
, but using a privateSymbol
so it can't be accessed properly).This PR adds a new
title
property onActivatedRoute
andActivatedRouteSnapshot
.Does this PR introduce a breaking change?
Other information