fix(forms): Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. #47034

dylhunn · 2022-08-04T02:48:35Z

Type inference in cases involving ControlConfig was previously not working as desired. This was because the compiler was enforcing that ControlConfig is a tuple -- which is not always that easy to prove! By relaxing this constraint a bit, and just inferring from ControlConfig as an array, the type inference catches many more cases, and is generally more correct.

Fixes #46442

dylhunn · 2022-08-04T03:58:01Z

~~TGP has one real failure which would need to fix forward.~~ (old TGP run)

AndrewKushnir

👍

packages/forms/src/form_builder.ts

dylhunn · 2022-08-08T20:51:59Z

I have updated this with a simpler implementation, and will run a fresh TGP.

Edit: TGP rerun.

packages/forms/src/form_builder.ts

…lidators]` shorthand in more cases. Type inference in cases involving `ControlConfig` was previously not working as desired. This was because the compiler was enforcing that `ControlConfig` is a *tuple* -- which is not always that easy to prove! By relaxing this constraint a bit, and just inferring from `ControlConfig` as an array, the type inference catches many more cases, and is generally more correct.

dylhunn · 2022-08-15T16:26:13Z

merge-assistance: the TGP failures are both flakes.

pkozlowski-opensource · 2022-08-17T11:32:17Z

This PR was merged into the repository by commit b302797.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.3/14.2.0) | | [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.3/14.2.0) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.3/14.2.0) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.3/14.2.0) | | [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.3/14.2.0) | | [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.3/14.2.0) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.3/14.2.0) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.3/14.2.0) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1420-2022-08-25) [Compare Source](angular/angular@14.1.3...14.2.0) ##### animations | Commit | Type | Description | | -- | -- | -- | | [b96e571897](angular/angular@b96e571) | fix | fix stagger timing not handling params ([#47208](angular/angular#47208)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [b380fdd59e](angular/angular@b380fdd) | feat | add a density cap for image srcsets ([#47082](angular/angular#47082)) | | [7ce497e5bc](angular/angular@7ce497e) | feat | add built-in Imgix loader ([#47082](angular/angular#47082)) | | [bff870db61](angular/angular@bff870d) | feat | add cloudflare loader ([#47082](angular/angular#47082)) | | [86e77a5d55](angular/angular@86e77a5) | feat | add Image directive skeleton ([#45627](angular/angular#45627)) ([#47082](angular/angular#47082)) | | [0566205a02](angular/angular@0566205) | feat | Add image lazy loading and fetchpriority ([#47082](angular/angular#47082)) | | [4e952ba216](angular/angular@4e952ba) | feat | add loaders for cloudinary & imagekit ([#47082](angular/angular#47082)) | | [e854a8cdde](angular/angular@e854a8c) | feat | add loading attr to NgOptimizedImage ([#47082](angular/angular#47082)) | | [8d3701cb4c](angular/angular@8d3701c) | feat | add warnings re: image distortion ([#47082](angular/angular#47082)) | | [d5f7da2120](angular/angular@d5f7da2) | feat | define public API surface for NgOptimizedImage directive ([#47082](angular/angular#47082)) | | [d3c3426aa4](angular/angular@d3c3426) | feat | detect LCP images in `NgOptimizedImage` and assert if `priority` is set ([#47082](angular/angular#47082)) | | [451b85ca17](angular/angular@451b85c) | feat | explain why width/height is required ([#47082](angular/angular#47082)) | | [586274fe65](angular/angular@586274f) | feat | provide an ability to exclude origins from preconnect checks in NgOptimizedImage ([#47082](angular/angular#47082)) | | [57f3386e5b](angular/angular@57f3386) | feat | support custom srcset attributes in NgOptimizedImage ([#47082](angular/angular#47082)) | | [7baf9a46cd](angular/angular@7baf9a4) | feat | verify that priority images have preconnect links ([#47082](angular/angular#47082)) | | [f81765b333](angular/angular@f81765b) | feat | warn if rendered size is much smaller than intrinsic ([#47082](angular/angular#47082)) | | [e2ab99b95e](angular/angular@e2ab99b) | fix | allow null/undefined to be passed to ngClass input ([#39280](angular/angular#39280)) ([#46906](angular/angular#46906)) | | [bedf537951](angular/angular@bedf537) | fix | allow null/undefined to be passed to ngStyle input ([#47069](angular/angular#47069)) | | [f9511bf6e8](angular/angular@f9511bf) | fix | avoid interacting with a destroyed injector ([#47243](angular/angular#47243)) | | [dc29e21b14](angular/angular@dc29e21) | fix | consider density descriptors with multiple digits as valid ([#47230](angular/angular#47230)) | | [801daf82d1](angular/angular@801daf8) | fix | detect `data:` and `blob:` inputs in `NgOptimizedImage` directive ([#47082](angular/angular#47082)) | | [fff8056e7f](angular/angular@fff8056) | fix | fix formatting on oversized image error ([#47188](angular/angular#47188)) ([#47232](angular/angular#47232)) | | [1ca2ce19ab](angular/angular@1ca2ce1) | fix | remove default for image width ([#47082](angular/angular#47082)) | | [c5db867ddc](angular/angular@c5db867) | fix | remove duplicate deepForEach ([#47189](angular/angular#47189)) | | [1cf43deb18](angular/angular@1cf43de) | fix | sanitize `rawSrc` and `rawSrcset` values in NgOptimizedImage directive ([#47082](angular/angular#47082)) | | [d71dfe931f](angular/angular@d71dfe9) | fix | set bound width and height onto host element ([#47082](angular/angular#47082)) | | [32caa8b669](angular/angular@32caa8b) | fix | support density descriptors with 2+ decimals ([#47197](angular/angular#47197)) ([#47232](angular/angular#47232)) | | [ae4405f0bf](angular/angular@ae4405f) | fix | throw if srcset is used with rawSrc ([#47082](angular/angular#47082)) | | [0c8eb8bc82](angular/angular@0c8eb8b) | perf | monitor LCP only for images without `priority` attribute ([#47082](angular/angular#47082)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [ea89677c12](angular/angular@ea89677) | feat | support more recent version of `tsickle` ([#47018](angular/angular#47018)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [d1e83e1b30](angular/angular@d1e83e1) | feat | add `createComponent` function ([#46685](angular/angular#46685)) | | [10becab70e](angular/angular@10becab) | feat | add `reflectComponentType` function ([#46685](angular/angular#46685)) | | [4b377d3a6d](angular/angular@4b377d3) | feat | introduce createApplication API ([#46475](angular/angular#46475)) | | [31429eaccc](angular/angular@31429ea) | feat | support TypeScript 4.8 ([#47038](angular/angular#47038)) | | [796840209c](angular/angular@7968402) | fix | align TestBed interfaces and implementation ([#46635](angular/angular#46635)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [426af91a42](angular/angular@426af91) | feat | add `FormBuilder.record()` method ([#46485](angular/angular#46485)) | | [b302797de4](angular/angular@b302797) | fix | Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. ([#47034](angular/angular#47034)) | ##### language-service | Commit | Type | Description | | -- | -- | -- | | [598b72bd05](angular/angular@598b72b) | feat | support fix the component missing member ([#46764](angular/angular#46764)) | ##### platform-browser | Commit | Type | Description | | -- | -- | -- | | [07606e3181](angular/angular@07606e3) | feat | add `isEmpty` method to the `TransferState` class ([#46915](angular/angular#46915)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [2b4d7f6733](angular/angular@2b4d7f6) | feat | support document reference in render functions ([#47032](angular/angular#47032)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [0abb67af59](angular/angular@0abb67a) | feat | allow guards and resolvers to be plain functions ([#46684](angular/angular#46684)) | | [75df404467](angular/angular@75df404) | feat | Create APIs for using Router without RouterModule ([#47010](angular/angular#47010)) | | [10289f1f6e](angular/angular@10289f1) | feat | expose resolved route title ([#46826](angular/angular#46826)) | | [8600732b09](angular/angular@8600732) | feat | Expose the default matcher for `Routes` used by the `Router` ([#46913](angular/angular#46913)) | | [422323cee0](angular/angular@422323c) | feat | improve typings for RouterLink boolean inputs ([#47101](angular/angular#47101)) | | [26ea97688c](angular/angular@26ea976) | feat | Make router directives standalone ([#46758](angular/angular#46758)) | | [2a43beec15](angular/angular@2a43bee) | fix | Fix route recognition behavior with some versions of rxjs ([#47098](angular/angular#47098)) | ##### service-worker | Commit | Type | Description | | -- | -- | -- | | [383090858c](angular/angular@3830908) | feat | support `sendRequest` as a `notificationclick` action ([#46912](angular/angular#46912)) | | [3f548610dd](angular/angular@3f54861) | fix | export NoNewVersionDetectedEvent ([#47044](angular/angular#47044)) | | [482b6119c2](angular/angular@482b611) | fix | update golden `index.md` ([#47044](angular/angular#47044)) | #### Special Thanks Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Bob Watson, Cédric Exbrayat, Dylan Hunn, Emmanuel Roux, FatalMerlin, George Kalpakas, Ilia Mirkin, Jan Kuehle, Jeremy Elbourn, Jessica Janiuk, JiaLiPassion, Kalbarczyk, Kara Erickson, Katie Hempenius, Kristiyan Kostadinov, Merlin, Paul Gschwendtner, Pawel Kozlowski, Tristan Sprößer, Victor Porof, angular-robot\[bot], dario-piotrowicz, ivanwonder and vyom  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1523 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

longhoangcode · 2022-09-06T04:28:01Z

Explicitly pass ControlConfig in FormBuilder#group type breaks in 14.2 with this changes
Pass in { email: ControlConfig<string>; } will return FormGroup<{ email: FormControl<string | undefined>; }> instead of FormGroup<{ email: FormControl<string>; }> with NonNullableFormBuilder
Playground Link modified from #46570
Switching to PermissiveControlConfig seem to work
Coud PermissiveControlConfig be exposed in public API? or other alternatives?
I need to pass in the type for controls with null or empty array initial value

angular-automatic-lock-bot · 2022-10-07T16:08:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

dylhunn added area: forms target: minor This PR is targeted for the next minor release forms: strictly typed labels Aug 4, 2022

ngbot bot modified the milestone: Backlog Aug 4, 2022

dylhunn force-pushed the formbuilder-controlconfig-fix branch 2 times, most recently from fe44d63 to 7922875 Compare August 4, 2022 03:14

dylhunn marked this pull request as ready for review August 4, 2022 03:58

dylhunn requested a review from AndrewKushnir August 4, 2022 20:30

AndrewKushnir approved these changes Aug 4, 2022

View reviewed changes

packages/forms/src/form_builder.ts Outdated Show resolved Hide resolved

dylhunn requested review from alxhub, atscott and jessicajaniuk and removed request for atscott, alxhub and jessicajaniuk August 8, 2022 17:39

dylhunn force-pushed the formbuilder-controlconfig-fix branch 2 times, most recently from c044483 to 0460078 Compare August 8, 2022 20:17

dylhunn added the action: merge The PR is ready for merge by the caretaker label Aug 8, 2022

dylhunn force-pushed the formbuilder-controlconfig-fix branch from 0460078 to c9045cb Compare August 8, 2022 20:45

dylhunn removed the action: merge The PR is ready for merge by the caretaker label Aug 8, 2022

dylhunn changed the title ~~fix(forms): Correctly infer FormBuilder types involving ControlConfig when value is an array.~~ fix(forms): Correctly infer FormBuilder types involving [value, validators] shorthand in more cases. Aug 8, 2022

dylhunn force-pushed the formbuilder-controlconfig-fix branch from c9045cb to ed3a5aa Compare August 8, 2022 20:53

AndrewKushnir approved these changes Aug 8, 2022

View reviewed changes

packages/forms/src/form_builder.ts Show resolved Hide resolved

packages/forms/src/form_builder.ts Outdated Show resolved Hide resolved

dylhunn force-pushed the formbuilder-controlconfig-fix branch from ed3a5aa to 300cb55 Compare August 15, 2022 07:36

dylhunn force-pushed the formbuilder-controlconfig-fix branch from 300cb55 to d0b38ea Compare August 15, 2022 07:57

dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 15, 2022

pkozlowski-opensource closed this in b302797 Aug 17, 2022

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2022

dylhunn deleted the formbuilder-controlconfig-fix branch October 17, 2022 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(forms): Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. #47034

fix(forms): Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. #47034

dylhunn commented Aug 4, 2022 •

edited

dylhunn commented Aug 4, 2022 •

edited

AndrewKushnir left a comment

dylhunn commented Aug 8, 2022 •

edited

dylhunn commented Aug 15, 2022

pkozlowski-opensource commented Aug 17, 2022

longhoangcode commented Sep 6, 2022 •

edited

angular-automatic-lock-bot bot commented Oct 7, 2022

fix(forms): Correctly infer FormBuilder types involving [value, validators] shorthand in more cases. #47034

fix(forms): Correctly infer FormBuilder types involving [value, validators] shorthand in more cases. #47034

Conversation

dylhunn commented Aug 4, 2022 • edited

dylhunn commented Aug 4, 2022 • edited

AndrewKushnir left a comment

Choose a reason for hiding this comment

dylhunn commented Aug 8, 2022 • edited

dylhunn commented Aug 15, 2022

pkozlowski-opensource commented Aug 17, 2022

longhoangcode commented Sep 6, 2022 • edited

angular-automatic-lock-bot bot commented Oct 7, 2022

fix(forms): Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. #47034

fix(forms): Correctly infer `FormBuilder` types involving `[value, validators]` shorthand in more cases. #47034

dylhunn commented Aug 4, 2022 •

edited

dylhunn commented Aug 4, 2022 •

edited

dylhunn commented Aug 8, 2022 •

edited

longhoangcode commented Sep 6, 2022 •

edited