fix(router): Fix route recognition behavior with some versions of rxj… #47112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular#47098) Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations internally. Context: angular@1160b81 fixes angular#47089 Note: This does not have a test because I was unable to identify the version of rxjs that would cause a failure here. PR Close angular#47098
|
This PR was merged into the repository by commit 439d77e. |
dylhunn
pushed a commit
that referenced
this pull request
Aug 10, 2022
#47098) (#47112) Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations internally. Context: 1160b81 fixes #47089 Note: This does not have a test because I was unable to identify the version of rxjs that would cause a failure here. PR Close #47098 PR Close #47112
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Aug 12, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.1/14.1.2) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.1/14.1.2) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.1/14.1.2) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.1/14.1.2) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.1/14.1.2) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.1/14.1.2) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.1/14.1.2) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.1/14.1.2) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.1.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1412-2022-08-10) [Compare Source](angular/angular@14.1.1...14.1.2) ##### core | Commit | Type | Description | | -- | -- | -- | | [5ff715c549](angular/angular@5ff715c) | fix | check if transplanted views are attached to change detector ([#​46974](angular/angular#46974)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [439d77e852](angular/angular@439d77e) | fix | Fix route recognition behavior with some versions of rxjs ([#​47098](angular/angular#47098)) ([#​47112](angular/angular#47112)) | #### Special Thanks 4javier, Andrew Kushnir, Andrew Scott, AntonioCardenas, Bob Watson, Bruno Barbosa, Eduardo Speroni, Edward, George Kalpakas, Jan Melcher, Kristiyan Kostadinov, Mladen Jakovljević, Paul Gschwendtner, Pawel Kozlowski, Roman Matusevich, Vovch, ashide2729, ileil and onrails <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1Mi4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1501 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch version of 2a43bee