Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): avoid errors for inputs with Object-builtin names #47220

Closed
wants to merge 1 commit into from
Closed

fix(compiler): avoid errors for inputs with Object-builtin names #47220

wants to merge 1 commit into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Aug 22, 2022

Using raw objects as a lookup structure will inadvertently find methods defined on
Object, where strings are expected. This causes errors downstream when string
operations are applied on functions.

This commit switches over to use Maps in the DOM element schema registry to fix
this category of issues.

Fixes #46936

@JoostK
fix(compiler): avoid errors for inputs with Object-builtin names
8bced8c 
Using raw objects as a lookup structure will inadvertently find methods defined on
`Object`, where strings are expected. This causes errors downstream when string
operations are applied on functions.

This commit switches over to use `Map`s in the DOM element schema registry to fix
this category of issues.

Fixes angular#46936
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Aug 22, 2022
@ngbot ngbot bot modified the milestone: Backlog Aug 22, 2022
pkozlowski-opensource
pkozlowski-opensource approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

pkozlowski-opensource
pkozlowski-opensource approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephperrott
josephperrott approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 23, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit cf0c53a.

AndrewKushnir pushed a commit that referenced this pull request Sep 6, 2022
@JoostK @AndrewKushnir
fix(compiler): avoid errors for inputs with Object-builtin names (#47220
0e35829 
)

Using raw objects as a lookup structure will inadvertently find methods defined on
`Object`, where strings are expected. This causes errors downstream when string
operations are applied on functions.

This commit switches over to use `Map`s in the DOM element schema registry to fix
this category of issues.

Fixes #46936

PR Close #47220
sbrshkappa pushed a commit to sbrshkappa/angular that referenced this pull request Sep 8, 2022
@JoostK @sbrshkappa
fix(compiler): avoid errors for inputs with Object-builtin names (ang…
724f951 
…ular#47220)

Using raw objects as a lookup structure will inadvertently find methods defined on
`Object`, where strings are expected. This causes errors downstream when string
operations are applied on functions.

This commit switches over to use `Map`s in the DOM element schema registry to fix
this category of issues.

Fixes angular#46936

PR Close angular#47220
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 11, 2022
Update angular monorepo to v14.2.1 (#1538)
5abfeca 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.0/14.2.1) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.0/14.2.1) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.0/14.2.1) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.0/14.2.1) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.0/14.2.1) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.0/14.2.1) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.0/14.2.1) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.0` -> `14.2.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.0/14.2.1) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.2.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1421-2022-09-07)

[Compare Source](angular/angular@14.2.0...14.2.1)

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [c0d7ac9ec2](angular/angular@c0d7ac9) | fix | improve formatting of image warnings ([#&#8203;47299](angular/angular#47299)) |
| [1875ce520a](angular/angular@1875ce5) | fix | use DOCUMENT token to query for preconnect links ([#&#8203;47353](angular/angular#47353)) |

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [0e35829580](angular/angular@0e35829) | fix | avoid errors for inputs with Object-builtin names ([#&#8203;47220](angular/angular#47220)) |

##### service-worker

| Commit | Type | Description |
| -- | -- | -- |
| [6091786696](angular/angular@6091786) | fix | include headers in requests for assets ([#&#8203;47260](angular/angular#47260)) |
| [28d33505fd](angular/angular@28d3350) | fix | only consider GET requests as navigation requests ([#&#8203;47263](angular/angular#47263)) |

#### Special Thanks

Aristeidis Bampakos, Asaf M, Bingo's Code, Bob Watson, Daniel Ostrovsky, George Kalpakas, Giovanni Alberto Rivas, Jeremy Elbourn, Jobayer Hossain, Joe Martin (Crowdstaffing), Joey Perrott, JoostK, Kara Erickson, Kristiyan Kostadinov, Maina Wycliffe, Sabareesh Kappagantu, Simona Cotin, Sonu Sindhu, Yann Provoost, abergquist, jaybell and vyom1611

<!-- CHANGELOG SPLIT MARKER -->

##### router

| Commit | Type | Description |
| -- | -- | -- |
| [5163e3d876](angular/angular@5163e3d) | feat | Add UrlTree constructor to public API ([#&#8203;47186](angular/angular#47186)) |

#### Special Thanks

Alan Agius, Alex Rickabaugh, Andrew Scott, Joey Perrott, Kara Erickson, Kristiyan Kostadinov and Pawel Kozlowski

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5Mi4zIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1538
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@jelbourn jelbourn Awaiting requested review from jelbourn

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

propName.toLowerCase is not a function
5 participants
@JoostK @AndrewKushnir @alfaproject @pkozlowski-opensource @josephperrott