refactor(animations): improve unit tests for stagger timing #47221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const animationDuration = 700; | ||
| const absoluteStaggerDelay = 500; | ||
|
|
||
| @Component({ |
There was a problem hiding this comment.
this gets wrongly indented by the formatter 馃槗
There was a problem hiding this comment.
ok I managed to fix it by shortening the it text 馃檪
improve the stagger timing unit tests added in angular#47208 by also checking that the duration and keyframes of the players are correct
jessicajaniuk
approved these changes
Aug 22, 2022
dario-piotrowicz
force-pushed
the
stagger-timing-tests-improvement
branch
from
8f8b2d6
to
ae40aee
Compare
jessicajaniuk
requested review from
jessicajaniuk
and removed request for
dylhunn and
jessicajaniuk
jessicajaniuk
added
action: merge
|
@jessicajaniuk I'm closing the PR as I will have to create a new one to fix the stagger issue you've found, so I guess it just makes more sense for me to include the updated unit tests in my next PR 馃檪 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the stagger timing unit tests added in #47208 by also checking
that the duration and keyframes of the players are correct
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information