fix(animations): fix stagger timing not handling params #47233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
changed the title
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly (this PR reinstates the changes done in angular#47208 which have been reverted because negative non-parametrized stagger values were not handled correctly, alongside the original changes the current commit also handles corretly negative non-parametrized values and improves unit testing) resolves angular#19786
dario-piotrowicz
force-pushed
the
stagger-timing-params-bugfix
branch
from
3683177
to
230bdb8
Compare
jessicajaniuk
added
area: animations
action: review
jessicajaniuk
approved these changes
Aug 23, 2022
jessicajaniuk
added
the
action: global presubmit
yeah of course 馃槄馃憤 |
|
Hello! Greetings, Flo |
|
@jessicajaniuk @dario-piotrowicz Hello! Will this feature coming soon, or is it histroy? I see the pull requests fails? Thx and greetings, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this change the stagger timing was being built during the
ast building instead of dynamically when visiting the stagger animation,
thus it could not handle params correctly, this change makes it so that
during ast building a timing ast is built instead and that ast is used
dynammically to build animations which can handle params correctly
(this PR reinstates the changes done in #47208 which have been reverted
because negative non-parametrized stagger values were not handled
correctly, alongside the original changes the current commit also
handles corretly negative non-parametrized values and improves unit
testing)
resolves #19786
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19786
Does this PR introduce a breaking change?
Other information