Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler-cli): remove enableIvy option #47346

Closed
wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Sep 5, 2022

This option has no longer any effect as Ivy is the only rendering engine.

BREAKING CHANGE: Angular compiler option enableIvy has been removed as Ivy is the only rendering engine.

};
}
const delegate = bazelHost.shouldSkipTsickleProcessing.bind(bazelHost);
bazelHost.shouldSkipTsickleProcessing = (fileName: string) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

@alan-agius4 alan-agius4 changed the title refactor(compiler): remove enableIvy options refactor(compiler): remove enableIvy option Sep 5, 2022
@alan-agius4 alan-agius4 changed the title refactor(compiler): remove enableIvy option refactor(compiler-cli): remove enableIvy option Sep 5, 2022
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 5, 2022
@ngbot ngbot bot added this to the Backlog milestone Sep 5, 2022
This option has no longer any effect as Ivy is the only rendering engine.

BREAKING CHANGE: Angular compiler option `enableIvy` has been removed as Ivy is the only rendering engine.
@alan-agius4 alan-agius4 marked this pull request as ready for review September 5, 2022 10:18
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 5, 2022
@alan-agius4
Copy link
Contributor Author

@alan-agius4 alan-agius4 removed the request for review from alxhub September 5, 2022 13:37
@pullapprove pullapprove bot requested a review from alxhub September 5, 2022 13:37
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 6, 2022
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 6, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 16f96ee.

@alan-agius4 alan-agius4 deleted the remove-enable-ivy branch September 6, 2022 18:36
sbrshkappa pushed a commit to sbrshkappa/angular that referenced this pull request Sep 8, 2022
This option has no longer any effect as Ivy is the only rendering engine.

BREAKING CHANGE: Angular compiler option `enableIvy` has been removed as Ivy is the only rendering engine.

PR Close angular#47346
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants