fix(common): rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive #47362

AndrewKushnir · 2022-09-06T20:03:17Z

As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the rawSrc attribute used for the NgOptimizedImage selector matching to ngSrc. The rawSrcset is also renamed to ngSrcset for consistency.

The motivation for this change is to align the attribute name better with other built-in directives, such as ngFor, ngIf, ngClass, ngStyle, etc.

Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.

Does this PR introduce a breaking change?

Yes
No, since the NgOptimizedImage directive is in the Developer Preview mode.

As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.

kara

LGTM!

jelbourn

LGTM

Reviewed-for: public-api, global-docs-approvers

…rective

AndrewKushnir · 2022-09-07T21:06:37Z

@kara @jelbourn FYI I've pushed a fixup commit to detect when the rawSrc is used and throw an error in this case: 0ab17f6. Could you please take a look and let me know what you think? Thank you.

jelbourn · 2022-09-07T22:16:01Z

@AndrewKushnir looked at the commit, LGTM

jelbourn

LGTM

Reviewed-for: global-docs-approvers

kara

LGTM

AndrewKushnir · 2022-09-07T23:09:19Z

Presubmit.

pkozlowski-opensource

LGTM!

Reviewed-for: public-api
Reviewed-for: fw-core
Reviewed-for: fw-common

dylhunn · 2022-09-09T21:25:39Z

This PR was merged into the repository by commit ca7bf65.

dylhunn · 2022-09-09T21:25:47Z

@AndrewKushnir This has been merged into minor, but needs a rebase to merge into patch.

…angular#47362) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close angular#47362

AndrewKushnir · 2022-09-09T21:57:45Z

@dylhunn thanks for the note, I've created a new patch-only PR: #47396. It should be ready for merge once CI is "green".

…#47362) (#47396) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close #47362 PR Close #47396

…angular#47362) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close angular#47362

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.1/14.2.2) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.1/14.2.2) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.1/14.2.2) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.1/14.2.2) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.1/14.2.2) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.1/14.2.2) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.1/14.2.2) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.1/14.2.2) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1422-2022-09-14) [Compare Source](angular/angular@14.2.1...14.2.2) ##### animations | Commit | Type | Description | | -- | -- | -- | | [937e6c5b3d](angular/angular@937e6c5) | fix | make sure that the animation function delay is applied ([#47285](angular/angular#47285)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [c9bdf9bab1](angular/angular@c9bdf9b) | fix | rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive ([#47362](angular/angular#47362)) ([#47396](angular/angular#47396)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [a3e1303f04](angular/angular@a3e1303) | fix | imply [@Optional](https://github.com/Optional) flag when a default value is provided ([#47242](angular/angular#47242)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [80c66a1e57](angular/angular@80c66a1) | fix | don't prevent default behavior for forms with method="dialog" ([#47308](angular/angular#47308)) | #### Special Thanks Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1548 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-10-10T16:08:54Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir added state: WIP area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release common: image directive labels Sep 6, 2022

ngbot bot modified the milestone: Backlog Sep 6, 2022

AndrewKushnir requested review from kara, pkozlowski-opensource and jelbourn and removed request for kara September 6, 2022 21:15

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Sep 6, 2022

AndrewKushnir marked this pull request as ready for review September 6, 2022 21:15

pullapprove bot requested a review from jessicajaniuk September 6, 2022 21:16

kara approved these changes Sep 6, 2022

View reviewed changes

jelbourn approved these changes Sep 7, 2022

View reviewed changes

pullapprove bot requested a review from alxhub September 7, 2022 18:55

fixup! fix(common): rename rawSrc -> ngSrc in NgOptimizedImage di…

0ab17f6

…rective

jelbourn approved these changes Sep 7, 2022

View reviewed changes

kara approved these changes Sep 7, 2022

View reviewed changes

AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 7, 2022

pkozlowski-opensource approved these changes Sep 8, 2022

View reviewed changes

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Sep 8, 2022

AndrewKushnir removed request for jessicajaniuk and alxhub September 8, 2022 02:31

dylhunn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 9, 2022

dylhunn closed this in ca7bf65 Sep 9, 2022

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(common): rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive #47362

fix(common): rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive #47362

AndrewKushnir commented Sep 6, 2022

kara left a comment

jelbourn left a comment •

edited

AndrewKushnir commented Sep 7, 2022

jelbourn commented Sep 7, 2022

jelbourn left a comment

kara left a comment

AndrewKushnir commented Sep 7, 2022

pkozlowski-opensource left a comment

dylhunn commented Sep 9, 2022

dylhunn commented Sep 9, 2022

AndrewKushnir commented Sep 9, 2022

angular-automatic-lock-bot bot commented Oct 10, 2022

fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive #47362

fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive #47362

Conversation

AndrewKushnir commented Sep 6, 2022

Does this PR introduce a breaking change?

kara left a comment

Choose a reason for hiding this comment

jelbourn left a comment • edited

Choose a reason for hiding this comment

AndrewKushnir commented Sep 7, 2022

jelbourn commented Sep 7, 2022

jelbourn left a comment

Choose a reason for hiding this comment

kara left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Sep 7, 2022

pkozlowski-opensource left a comment

Choose a reason for hiding this comment

dylhunn commented Sep 9, 2022

dylhunn commented Sep 9, 2022

AndrewKushnir commented Sep 9, 2022

angular-automatic-lock-bot bot commented Oct 10, 2022

fix(common): rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive #47362

fix(common): rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive #47362

jelbourn left a comment •

edited