feat(platform-browser): include Location mocks into testing environment by default #47413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
state: WIP
area: common
AndrewKushnir
force-pushed
the
location_mock
branch
from
b7f6d0b
to
d6509e5
Compare
…nt by default Currently, the `Location` and `LocationStrategy` mocks are added by the Router's testing module (the `RouterTestingModule`). However, the `Location` and `LocationStrategy` abstractions are parts of the `@angular/common` package and can be used outside of the Router logic to interact with the location. This PR adds the `Location` and `LocationStrategy` mocks into the `BrowserTestingModule` NgModule, which is used for environment setup in TestBed. Adding the mocks there has 2 main advantages: - `Location` and `LocationStrategy` mocks will always be setup when you use TestBed (note: if you provide location mocks in the TestBed.configureTestingModule, custom mocks would still be used), which would cover cases when the `Location` is used in apps code directly. - The Router would not need to provide the mocks for abstractions that belong to the different package (`@angular/common`), which should help simplify the standalone Router APIs for testing.
AndrewKushnir
force-pushed
the
location_mock
branch
from
d6509e5
to
18ef292
Compare
|
Closing in favor of #47674. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
LocationandLocationStrategymocks are added by the Router's testing module (theRouterTestingModule). However, theLocationandLocationStrategyabstractions are parts of the@angular/commonpackage and can be used outside of the Router logic to interact with the location.This PR adds the
LocationandLocationStrategymocks into theBrowserTestingModuleNgModule, which is used for environment setup in TestBed. Adding the mocks there has 2 main advantages:LocationandLocationStrategymocks will always be setup when you use TestBed (note: if you provide location mocks in the TestBed.configureTestingModule, custom mocks would still be used), which would cover cases when theLocationis used in apps code directly.@angular/common), which should help simplify the standalone Router APIs for testing.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?