perf(compiler-cli): cache source file for reporting type-checking diagnostics #47471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
action: review
alxhub
approved these changes
Sep 20, 2022
packages/compiler-cli/src/ngtsc/typecheck/diagnostics/src/diagnostic.ts
Outdated
Show resolved
Hide resolved
JoostK
force-pushed
the
ngtsc/ttc/cache-template-sf
branch
from
6211b4e
to
e73ea93
Compare
…gnostics When reporting type-checking diagnostics in external templates we create a `ts.SourceFile` of the template text, as this is needed to report Angular template diagnostics using TypeScript's diagnostics infrastructure. Each reported diagnostic would create its own `ts.SourceFile`, resulting in repeatedly parsing of the template text and potentially high memory usage if the template is large and there are many diagnostics reported. This commit caches the parsed template in the template mapping, such that all reported diagnostics get to reuse the same `ts.SourceFile`. Closes angular#47470
JoostK
force-pushed
the
ngtsc/ttc/cache-template-sf
branch
from
e73ea93
to
289e7f5
Compare
JoostK
added
action: merge
|
merge-assistance: this needs reapproval for a post-review fixup. |
alxhub
approved these changes
Sep 21, 2022
pkozlowski-opensource
removed
the
merge: caretaker note
|
@JoostK it doesn't merge cleanly to a patch branch. I'm going to re-label it as |
pkozlowski-opensource
added
target: minor
|
This PR was merged into the repository by commit 8fcadaa. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting type-checking diagnostics in external templates we create a
ts.SourceFileof the template text, as this is needed to report Angular template diagnostics using TypeScript's diagnostics infrastructure. Each reported diagnostic would create its ownts.SourceFile, resulting in repeatedly parsing of the template text and potentially high memory usage if the template is large and there are many diagnostics reported. This commit caches the parsed template in the template mapping, such that all reported diagnostics get to reuse the samets.SourceFile.Closes #47470