New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): update element schema #47552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crisbeto as discussed, the content of the files if auto-generated, instructions in: https://github.com/angular/angular/blob/main/packages/compiler/test/schema/dom_element_schema_registry_spec.ts#L194-L197
We should run this scrip to see if maybe there are other tags that we are missing. It will also require security review:
angular/packages/compiler/src/schema/dom_element_schema_registry.ts
Lines 65 to 74 in 6a88bad
// ================================================================================================= | |
// ================================================================================================= | |
// =========== S T O P - S T O P - S T O P - S T O P - S T O P - S T O P =========== | |
// ================================================================================================= | |
// ================================================================================================= | |
// | |
// DO NOT EDIT THIS DOM SCHEMA WITHOUT A SECURITY REVIEW! | |
// | |
// Newly added properties must be security reviewed and assigned an appropriate SecurityContext in | |
// dom_security_schema.ts. Reach out to mprobst & rjamet for details. |
b44fa32
to
da78952
Compare
I've run the script and pushed the changes in the fixup commit. |
Also, the commit message should be updated if the change is more than just adding |
da78952
to
3c45f6f
Compare
For context, the review above is from the internal security team. @alxhub I've updated the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: fw-security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: fw-security
This PR was merged into the repository by commit 48b354a. |
Reverting. This caused a breakage in Google3. |
For future reference: there was an app using the now-deprecated |
3c45f6f
to
f6eef42
Compare
Updates the DOM element schema to add the `hgroup` element and to include some properties that weren't supported the last time the schema was updated. Fixes angular#47545.
f6eef42
to
38847df
Compare
I've resolved the issue that caused the change to be reverted and I've run a TGP just in case. |
This PR was merged into the repository by commit 39b72e2. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the DOM element schema to add the
hgroup
element and to include some properties that weren't supported the last time the schema was updated.Fixes #47545.