Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): update element schema #47552

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 27, 2022

Updates the DOM element schema to add the hgroup element and to include some properties that weren't supported the last time the schema was updated.

Fixes #47545.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 27, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 27, 2022
@crisbeto crisbeto marked this pull request as ready for review September 27, 2022 07:36
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto as discussed, the content of the files if auto-generated, instructions in: https://github.com/angular/angular/blob/main/packages/compiler/test/schema/dom_element_schema_registry_spec.ts#L194-L197

We should run this scrip to see if maybe there are other tags that we are missing. It will also require security review:

// =================================================================================================
// =================================================================================================
// =========== S T O P - S T O P - S T O P - S T O P - S T O P - S T O P ===========
// =================================================================================================
// =================================================================================================
//
// DO NOT EDIT THIS DOM SCHEMA WITHOUT A SECURITY REVIEW!
//
// Newly added properties must be security reviewed and assigned an appropriate SecurityContext in
// dom_security_schema.ts. Reach out to mprobst & rjamet for details.

@crisbeto
Copy link
Member Author

I've run the script and pushed the changes in the fixup commit.

@alxhub
Copy link
Member

alxhub commented Sep 30, 2022

Also, the commit message should be updated if the change is more than just adding hgroup.

@crisbeto crisbeto changed the title fix(compiler): allow hgroup element fix(compiler): update element schema Oct 3, 2022
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 3, 2022
@crisbeto
Copy link
Member Author

crisbeto commented Oct 3, 2022

For context, the review above is from the internal security team. @alxhub I've updated the PR description.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 10, 2022
@crisbeto crisbeto removed the request for review from jelbourn October 10, 2022 20:20
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 48b354a.

@jessicajaniuk
Copy link
Contributor

Reverting. This caused a breakage in Google3.

@jessicajaniuk jessicajaniuk reopened this Oct 11, 2022
@jessicajaniuk jessicajaniuk added state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Oct 11, 2022
@crisbeto
Copy link
Member Author

For future reference: there was an app using the now-deprecated content element which was removed when I ran the script.

Updates the DOM element schema to add the `hgroup` element and to include some properties that weren't supported the last time the schema was updated.

Fixes angular#47545.
@crisbeto
Copy link
Member Author

I've resolved the issue that caused the change to be reverted and I've run a TGP just in case.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Oct 11, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 39b72e2.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'hgroup' is not a known element
6 participants