fix(localize): add polyfill in polyfills array instead of polyfills.ts #47569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
|
|
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 29, 2022
This update is needed to implement the changes in `ng add localize` angular#47569
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 29, 2022
This update is needed to implement the changes in `ng add localize` angular#47569
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 29, 2022
- This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 29, 2022
- This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 29, 2022
- This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files.
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Sep 30, 2022
- This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files.
AndrewKushnir
pushed a commit
that referenced
this pull request
Sep 30, 2022
- This update is needed to implement the changes in `ng add localize` #47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files. PR Close #47584
With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects.
alan-agius4
force-pushed
the
localize-schematic
branch
from
517cc31
to
f78ea82
Compare
alan-agius4
requested review from
AndrewKushnir
and removed request for
dgp1130
alan-agius4
added
the
action: review
AndrewKushnir
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
@alan-agius4 the changes look good 👍
Quick question: do we have tests to cover error cases (file that we try to patch is not found, the value of the polyfills field is unexpected, etc)? Just curious what the DX would look like in those cases and if there is a need to improve error messages, etc (in separate PR(s)).
In general even during migrations we expect the project/builder target to be in a working state. This is because this is validated when running the CLI and an error would be displayed when there are invalid options. In the case a file is not found an error will be displayed. |
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit 400a6b5. |
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
) - This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files. PR Close angular#47584
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
angular#47569) With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects. PR Close angular#47569
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
) - This update is needed to implement the changes in `ng add localize` angular#47569 - Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail. - Remove `require.context` from test.ts integration test, as this is no longer needed. - Update payloads golden files. PR Close angular#47584
pterratpro
pushed a commit
to pterratpro/angular-fr
that referenced
this pull request
Oct 4, 2022
angular#47569) With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects. PR Close angular#47569
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default.
This commit changes the way on how the polyfill is added to the projects.