feat(router): add a migration to remove relativeLinkResolution usages
#47604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
feature
AndrewKushnir
added
action: review
atscott
approved these changes
Oct 3, 2022
AndrewKushnir
force-pushed
the
link-resolution-migration
branch
2 times, most recently
from
0498f5d
to
5cf2142
Compare
|
@atscott I've added a google3 migration logic as requested. Thank you. |
atscott
approved these changes
Oct 4, 2022
crisbeto
reviewed
Oct 5, 2022
|
Note: this PR needs some additional work to separate lookups from writes, based on #47599 (comment), adding the "blocked" label for now. |
AndrewKushnir
force-pushed
the
link-resolution-migration
branch
from
5cf2142
to
b936eec
Compare
|
This PR is now updated based on the feedback from @crisbeto. The PR is ready for re-review. Thank you. |
AndrewKushnir
force-pushed
the
link-resolution-migration
branch
from
b936eec
to
10a7f1b
Compare
AndrewKushnir
added
action: presubmit
As of Angular v15, the deprecated `relativeLinkResolution` config option of the Router is removed. This migration cleans up (removes) the `relativeLinkResolution` fields from the Router config objects in applications code.
```ts
import { RouterModule } from '@angular/router';
RouterModule.forRoot([], {
relativeLinkResolution: 'legacy',
enableTracing: false,
});
```
```ts
import { RouterModule } from '@angular/router';
RouterModule.forRoot([], {
// the `relativeLinkResolution` is removed
enableTracing: false,
});
```
AndrewKushnir
force-pushed
the
link-resolution-migration
branch
from
10a7f1b
to
8d21eac
Compare
AndrewKushnir
added
action: merge
|
Merge-assistance: this PR would require an extra patch (cl/479482886) applied to the sync CL. |
|
This PR was merged into the repository by commit 7bee28d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Angular v15, the deprecated
relativeLinkResolutionconfig option of the Router is removed. This migration cleans up (removes) therelativeLinkResolutionfields from the Router config objects in applications code.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?