docs(core): deprecate providedIn: NgModule and providedIn: 'any'
#47616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates the above two forms of `providedIn`. DEPRECATED: - The ability to pass an `NgModule` to the `providedIn` option for `@Injectable` and `InjectionToken` is now deprecated. `providedIn: NgModule` was intended to be a tree-shakable alternative to NgModule providers. It does not have wide usage, and in most cases is used incorrectly, in circumstances where `providedIn: 'root'` should be preferred. If providers should truly be scoped to a specific NgModule, use `NgModule.providers` instead. - The ability to set `providedIn: 'any'` for an `@Injectable` or `InjectionToken` is now deprecated. `providedIn: 'any'` is an option with confusing semantics and is almost never used apart from a handful of esoteric cases internal to the framework.
alxhub
force-pushed
the
v15/deprecations/providedIn
branch
from
6674034
to
f1043d9
Compare
pkozlowski-opensource
approved these changes
Oct 4, 2022
pkozlowski-opensource
added
the
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
pkozlowski-opensource
added
the
target: major
|
This PR was merged into the repository by commit e3cef4a. |
mprobst
pushed a commit
to mprobst/angular
that referenced
this pull request
Oct 5, 2022
…ngular#47616) This commit deprecates the above two forms of `providedIn`. DEPRECATED: - The ability to pass an `NgModule` to the `providedIn` option for `@Injectable` and `InjectionToken` is now deprecated. `providedIn: NgModule` was intended to be a tree-shakable alternative to NgModule providers. It does not have wide usage, and in most cases is used incorrectly, in circumstances where `providedIn: 'root'` should be preferred. If providers should truly be scoped to a specific NgModule, use `NgModule.providers` instead. - The ability to set `providedIn: 'any'` for an `@Injectable` or `InjectionToken` is now deprecated. `providedIn: 'any'` is an option with confusing semantics and is almost never used apart from a handful of esoteric cases internal to the framework. PR Close angular#47616
yharaskrik
pushed a commit
to yharaskrik/angular
that referenced
this pull request
Oct 5, 2022
…ngular#47616) This commit deprecates the above two forms of `providedIn`. DEPRECATED: - The ability to pass an `NgModule` to the `providedIn` option for `@Injectable` and `InjectionToken` is now deprecated. `providedIn: NgModule` was intended to be a tree-shakable alternative to NgModule providers. It does not have wide usage, and in most cases is used incorrectly, in circumstances where `providedIn: 'root'` should be preferred. If providers should truly be scoped to a specific NgModule, use `NgModule.providers` instead. - The ability to set `providedIn: 'any'` for an `@Injectable` or `InjectionToken` is now deprecated. `providedIn: 'any'` is an option with confusing semantics and is almost never used apart from a handful of esoteric cases internal to the framework. PR Close angular#47616
|
Can the providers docs be updated based on this as well? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the above two forms of
providedIn.DEPRECATED:
NgModuleto theprovidedInoption for@InjectableandInjectionTokenis now deprecated.providedIn: NgModulewas intended to be a tree-shakable alternative to NgModule providers. It does not have wide usage, and in most cases is used incorrectly, in circumstances whereprovidedIn: 'root'should be preferred. If providers should truly be scoped to a specific NgModule, useNgModule.providersinstead.providedIn: 'any'for an@InjectableorInjectionTokenis now deprecated.providedIn: 'any'is an option with confusing semantics and is almost never used apart from a handful of esoteric cases internal to the framework.