New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): Remove deprecated relativeLinkResolution #47623
Conversation
The `relativeLinkResolution` is no longer supported. The only behavior now is the correct behavior. BREAKING CHANGE: `relativeLinkResolution` is no longer configurable in the Router. This option was used as a means to opt out of a bug fix.
07f2a4a
to
34e9f1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a quick question regarding InternalExtraOptions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
caretaker note: this requires an update to the patch (cl/478846313) |
This PR was merged into the repository by commit 7b89d95. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
relativeLinkResolution
is no longer supported. The only behavior now is the correct behavior.BREAKING CHANGE:
relativeLinkResolution
is no longer configurable in the Router. This option was used as a means to opt out of a bug fix.