feat(router): merge RouterLinkWithHref into RouterLink
#47630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
feature
AndrewKushnir
force-pushed
the
final_router_link_merge
branch
from
2d51b7e
to
0716068
Compare
This commit updates the `RouterLink` to extend the selector to also include `<a>` and `<area>` elements, which were previously matched by the `RouterLinkWithHref` directive. The code of the directives was merged together (since there was a lot of duplication) and this commit finalizes the merge. The `RouterLinkWithHref` becomes an alias of the `RouterLink` directive. Now there is no need to import and use the `RouterLinkWithHref` class, the `RouterLink` directive will match any element that has the `routerLink` attribute. DEPRECATED: The `RouterLinkWithHref` directive is deprecated, use the `RouterLink` directive instead. The `RouterLink` contains the code from the `RouterLinkWithHref` to handle elements with `href` attributes.
AndrewKushnir
force-pushed
the
final_router_link_merge
branch
from
0716068
to
fb06e58
Compare
AndrewKushnir
added
action: review
atscott
approved these changes
Oct 5, 2022
| @@ -33,7 +33,7 @@ | |||
| "cli-hello-world-lazy": { | |||
| "uncompressed": { | |||
| "runtime": 2835, | |||
| "main": 226404, | |||
| "main": 225113, | |||
atscott
approved these changes
Oct 5, 2022
jessicajaniuk
approved these changes
Oct 5, 2022
jessicajaniuk
added
action: merge
|
Note to self: this is blocked by the internal cleanup. |
AndrewKushnir
removed
the
action: global presubmit
|
Merge-assistance: internal cleanup is completed, this PR is ready for merge. Please merge and sync on its own (to simplify a rollback if needed). |
|
This PR was merged into the repository by commit f73ef21. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
RouterLinkto extend the selector to also include<a>and<area>elements, which were previously matched by theRouterLinkWithHrefdirective. The code of the directives was merged together (since there was a lot of duplication) and this commit finalizes the merge. TheRouterLinkWithHrefbecomes an alias of theRouterLinkdirective.Now there is no need to import and use the
RouterLinkWithHrefclass, theRouterLinkdirective will match any element that has therouterLinkattribute.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?