fix(http): better handle unexpected undefined XSRF tokens
#47683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HttpXsrfTokenExtractor` allows returning `string|null` for an XSRF token, and the interceptor checked if the returned token is `null`. However, some implementations return `undefined` instead (behind an `any`) type, which caused the interceptor to crash when trying to set an `undefined` value for the header. This commit makes the XSRF interceptor a little more resilient against such broken implementations of the `HttpXsrfTokenExtractor` interface.
alxhub
added
action: merge
jessicajaniuk
approved these changes
Oct 6, 2022
|
This PR was merged into the repository by commit ea16a98. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpXsrfTokenExtractorallows returningstring|nullfor an XSRF token, and the interceptor checked if the returned token isnull. However, some implementations returnundefinedinstead (behind anany) type, which caused the interceptor to crash when trying to set anundefinedvalue for the header.This commit makes the XSRF interceptor a little more resilient against such broken implementations of the
HttpXsrfTokenExtractorinterface.