fix(localize): update ng add schematic to support Angular CLI version 15 #47763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
ng-add-localize-types
branch
from
e8e4bd1
to
f0f0b38
Compare
alan-agius4
force-pushed
the
ng-add-localize-types
branch
from
f0f0b38
to
10801c1
Compare
alan-agius4
added
the
target: rc
alan-agius4
force-pushed
the
ng-add-localize-types
branch
2 times, most recently
from
0adb742
to
431c079
Compare
alan-agius4
force-pushed
the
ng-add-localize-types
branch
from
431c079
to
6793e84
Compare
alan-agius4
requested review from
AndrewKushnir
and removed request for
dgp1130
alan-agius4
added
the
action: review
jessicajaniuk
approved these changes
Oct 13, 2022
Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes angular#47677
alan-agius4
force-pushed
the
ng-add-localize-types
branch
from
6793e84
to
301a8b5
Compare
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 14, 2022
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
AndrewKushnir
approved these changes
Oct 14, 2022
pullapprove
bot
requested review from
dylhunn,
jessicajaniuk and
pkozlowski-opensource
AndrewKushnir
approved these changes
Oct 14, 2022
alan-agius4
added
action: merge
jessicajaniuk
approved these changes
Oct 14, 2022
|
This PR was merged into the repository by commit c9541f4. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 17, 2022
… 15 (#47763) Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes #47677 PR Close #47763
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Oct 21, 2022
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
Oct 21, 2022
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
Oct 21, 2022
…ze package is installed The `@angular/localize` entrypoint now exposes the global `$localize` method type. See: angular/angular#47763 (cherry picked from commit b29ae2f)
nouraellm
pushed a commit
to nouraellm/angular
that referenced
this pull request
Nov 6, 2022
… 15 (angular#47763) Prior to this, the `@angular/localize/init` was added as a polyfill which caused the `@angular/localize` types not to be included in the TypeScript program which caused errors such as the below: ``` Error: src/app/app.component.ts:9:11 - error TS2304: Cannot find name '$localize'. ``` With the recent changes in the CLI (angular/angular-cli#24032), adding `@angular/localize/init` as polyfil or in the `main.server.ts` is no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add `@angular/localize/init` as an additional entrypoint. This change also exposes the `$localize` method as a global when importing `@angular/localize`. Closes angular#47677 PR Close angular#47763
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the
@angular/localize/initwas added as a polyfill which caused the@angular/localizetypes not to be included in the TypeScript program which caused errors such as the below:With the recent changes in the CLI (angular/angular-cli#24032), adding
@angular/localize/initas polyfil or in themain.server.tsis no longer necessary. Instead we add this as a TypeScript type. When users are running in JIT mode, we add@angular/localize/initas an additional entrypoint.This change also exposes the
$localizemethod as a global when importing@angular/localize.Closes #47677