New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): Don't warn about image distortion if fill mode is enabled #47824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atcastle looks good, just a small request to add a comment into the code (see below). Thank you.
The image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox.
b8a6d84
to
a1eec0d
Compare
This PR was merged into the repository by commit 6b9b472. |
angular#47824) The image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox. PR Close angular#47824
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
angular#47824) The image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox. PR Close angular#47824
This PR disables the image distortion warning (when rendered aspect ratio is noticeably different than intrinsic) when in fill mode. The warning doesn't make sense with fill mode, where the user may want the image to stretch, crop or letterbox, depending on their styling. Test is e2e only because this warning only fires after the image is loaded.