Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(forms): don't mutate validators array (#47830)" #47845

Closed

Conversation

pkozlowski-opensource
Copy link
Member

This reverts commit 0329c13 from PR #47830 as it might be causing G3 test failures.

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 24, 2022
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review October 24, 2022 14:04
@pullapprove pullapprove bot requested a review from dylhunn October 24, 2022 14:04
@ngbot ngbot bot added this to the Backlog milestone Oct 24, 2022
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource
Copy link
Member Author

This PR was merged into the repository by commit 9bfedb1.

pkozlowski-opensource added a commit that referenced this pull request Oct 25, 2022
nouraellm pushed a commit to nouraellm/angular that referenced this pull request Nov 6, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants