API Docs for the new provideHttpClient
#47901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds documentation and API tagging for `provideHttpClient` and the `with*` feature functions.
This rename reflects what the function actually does. Although the intention is still not to have two different interceptor mechanisms, that is now communicated in the docs for the function instead of in its name. Fixes angular#47764
pullapprove
bot
requested review from
AndrewKushnir,
dylhunn and
jessicajaniuk
AndrewKushnir
approved these changes
Oct 29, 2022
Comment on lines
+56
to
+57
| * `withInterceptors(...)` feature. | ||
| * |
There was a problem hiding this comment.
nit (not a blocker for this PR): it might be helpful to have a small code snippet to show the structure of the provideHttpClient call (how you would use it with bootstrapApplication call). Since other with* functions refer to this one - it'd be a good location to have an example.
AndrewKushnir
approved these changes
Oct 29, 2022
atscott
approved these changes
Oct 31, 2022
dylhunn
approved these changes
Nov 1, 2022
|
This PR was merged into the repository by commit febf29d. |
nouraellm
pushed a commit
to nouraellm/angular
that referenced
this pull request
Nov 6, 2022
…gular#47901) This commit adds documentation and API tagging for `provideHttpClient` and the `with*` feature functions. PR Close angular#47901
nouraellm
pushed a commit
to nouraellm/angular
that referenced
this pull request
Nov 6, 2022
angular#47901) This rename reflects what the function actually does. Although the intention is still not to have two different interceptor mechanisms, that is now communicated in the docs for the function instead of in its name. Fixes angular#47764 PR Close angular#47901
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…gular#47901) This commit adds documentation and API tagging for `provideHttpClient` and the `with*` feature functions. PR Close angular#47901
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
angular#47901) This rename reflects what the function actually does. Although the intention is still not to have two different interceptor mechanisms, that is now communicated in the docs for the function instead of in its name. Fixes angular#47764 PR Close angular#47901
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.