Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): fix redirectTo on named outlets #47921

Closed

Conversation

pixeldublu
Copy link
Contributor

fix(router): fix redirectTo on named outlets

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #33783

What is the new behavior?

You can now redirect your named outlets. Useful when creating sub navigations like sub page tabs and such.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(router): fix redirectTo on named outlets
@pullapprove pullapprove bot requested a review from atscott October 30, 2022 12:48
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: router labels Oct 31, 2022
@ngbot ngbot bot modified the milestone: Backlog Oct 31, 2022
atscott
atscott previously approved these changes Oct 31, 2022
packages/router/test/config.spec.ts Show resolved Hide resolved
@atscott atscott added the target: patch This PR is targeted for the next patch release label Oct 31, 2022
fix(router): fix redirectTo on named outlets
@pixeldublu
Copy link
Contributor Author

@atscott What is the flow on getting this fix on the main branch ? Should I cherry pick it there ? Thanks

fix(router): fix redirectTo on named outlets
@atscott
Copy link
Contributor

atscott commented Oct 31, 2022

@pixeldublu Ah, I see you are targeting 14.2.x branch. You will want to create your PR to merge to main and our tooling will merge to all patch versions as long as there's no conflict

@pixeldublu
Copy link
Contributor Author

@atscott Oh my bad then. I discovered it on 14.2.x

Created now #47927 with target main ( You can re-approve there and I will close this one )

Thanks!

@pixeldublu pixeldublu closed this Oct 31, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants