Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): hardening rules related to the attribute order on <iframe> elements #47935

Closed
wants to merge 1 commit into from
Closed

fix(core): hardening rules related to the attribute order on <iframe> elements #47935

wants to merge 1 commit into from

Commits on Nov 2, 2022

  1. fix(core): hardening rules related to the attribute order on iframe e… 

    …lements

This commit updates the logic related to the attribute order on iframes and makes the rules more strict. There is a set of iframe attributes that may affect the behavior of an iframe, this change enforces that these attributes are applied before an `src` or `srcdoc` attributes are applied to an iframe, so that they are taken into account.

If Angular detects that some of the attributes are set after the `src` or `srcdoc`, it throws an error message, which contains the name of ann attribute that is causing the problem and the name of a Component where an iframe is located. In most cases, it should be enough to change the order of attributes in a template to move the `src` or `srcdoc` ones to the very end.

BREAKING CHANGE:

Existing iframe usages may have `src` or `srcdoc` preceding other attributes. Such usages may need to be updated to ensure compliance with the new stricter rules around iframe bindings.
    @AndrewKushnir @alxhub
    AndrewKushnir authored and alxhub committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b6795c1 View commit details
    Browse the repository at this point in the history