Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): Improve a very commonly viewed error message by adding a guide #47969

Closed
wants to merge 1 commit into from
Closed

fix(forms): Improve a very commonly viewed error message by adding a guide #47969

wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Nov 4, 2022 •
edited

A Github issue about an arcane-sounding Forms error is one of the repo's top-ten most visited pages. Indeed, it is super vague and can show up for many different reasons. This converts the error to RuntimeErrorCode and adds a dedicated guide to explain how to solve it.

@dylhunn dylhunn added area: docs area: forms forms: directives target: minor This PR is targeted for the next minor release labels Nov 4, 2022
@ngbot ngbot bot modified the milestone: Backlog Nov 4, 2022
@angular-robot angular-robot bot removed the area: docs label Nov 4, 2022
@dylhunn dylhunn mentioned this pull request Nov 4, 2022
Closed
@dylhunn dylhunn marked this pull request as ready for review November 4, 2022 00:53
@dylhunn dylhunn added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 4, 2022
@dylhunn dylhunn added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Nov 4, 2022
AndrewKushnir
AndrewKushnir reviewed Nov 4, 2022
View reviewed changes
goldens/public-api/forms/errors.md Outdated Show resolved Hide resolved
packages/forms/src/directives/shared.ts Outdated Show resolved Hide resolved
packages/forms/src/directives/shared.ts Outdated Show resolved Hide resolved
@dylhunn dylhunn force-pushed the value-accessor-error branch 2 times, most recently from 8cb8519 to a059bb3 Compare November 4, 2022 01:11
AndrewKushnir
AndrewKushnir approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@mary-poppins
Copy link

You can preview b4f8a67 at https://pr47969-b4f8a67.ngbuilds.io/.
You can preview eae3ebb at https://pr47969-eae3ebb.ngbuilds.io/.
You can preview a059bb3 at https://pr47969-a059bb3.ngbuilds.io/.

pkozlowski-opensource
pkozlowski-opensource approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

aio/content/errors/NG1203.md Outdated Show resolved Hide resolved
@Natarajd

This comment was marked as outdated.

Sign in to view
@Natarajd Natarajd added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 4, 2022
@Natarajd
Copy link

Natarajd commented Nov 4, 2022 •
edited by devversion

Caretaker Note: Flaky Test Failures for g3. Please ignore the google-internal-tests

@jessicajaniuk jessicajaniuk removed the request for review from atscott November 4, 2022 16:02
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2022
@ngbot
Copy link

ngbot bot commented Nov 4, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    failure status "ci/circleci: test" is failing
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 4, 2022
@mary-poppins
Copy link

You can preview 58e9d0e at https://pr47969-58e9d0e.ngbuilds.io/.

@dylhunn dylhunn force-pushed the value-accessor-error branch 2 times, most recently from a935060 to 99a8dcb Compare November 7, 2022 20:37
@mary-poppins
Copy link

You can preview 99a8dcb at https://pr47969-99a8dcb.ngbuilds.io/.

@dylhunn
fix(forms): Improve a very commonly viewed error message by adding a …
d074199 
…guide.

[A Github issue](angular#43821) about an arcane-sounding Forms error is one of the repo's top-ten most visited pages. This converts the error to `RuntimeErrorCode` and adds a dedicated guide to explain how to solve it.
@mary-poppins
Copy link

You can preview d074199 at https://pr47969-d074199.ngbuilds.io/.

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 7, 2022
AndrewKushnir
AndrewKushnir approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

goldens/size-tracking/integration-payloads.json Show resolved Hide resolved
@dylhunn
Copy link
Contributor Author

dylhunn commented Nov 7, 2022

Caretaker Note: Please ignore the google-internal-tests status. Last run before pushing passed

@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Nov 7, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 604cdb7.

AndrewKushnir pushed a commit that referenced this pull request Nov 8, 2022
@dylhunn @AndrewKushnir
fix(forms): Improve a very commonly viewed error message by adding a …
2625dc1 
…guide. (#47969)

[A Github issue](#43821) about an arcane-sounding Forms error is one of the repo's top-ten most visited pages. This converts the error to `RuntimeErrorCode` and adds a dedicated guide to explain how to solve it.

PR Close #47969
@AndrewKushnir
Copy link
Contributor

@dylhunn there was a merge conflict with the 14.2.x branch, so this PR was merged into 15.0.x and main branches only. Could you please create a new PR and target the 14.2.x branch if the change should be included there as well? Thank you.

@dylhunn
Copy link
Contributor Author

dylhunn commented Nov 8, 2022 •
edited

it's fine to just merge it into 15.0.x and later. That's what I intended anyway actually -- we don't usually maintain three branches :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@dylhunn @trekladyone
fix(forms): Improve a very commonly viewed error message by adding a …
e3d7b22 
…guide. (angular#47969)

[A Github issue](angular#43821) about an arcane-sounding Forms error is one of the repo's top-ten most visited pages. This converts the error to `RuntimeErrorCode` and adds a dedicated guide to explain how to solve it.

PR Close angular#47969
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: forms forms: directives merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dylhunn @mary-poppins @Natarajd @AndrewKushnir @pkozlowski-opensource @jessicajaniuk