fix(common): Add fetchpriority to ngOptimizedImage preloads #48010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fetchpriority='high' to ngOptimizedImage preloads to so their priority matches the priority of the image element itself
AndrewKushnir
added
action: review
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit 1d1e33e. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 10, 2022
Add fetchpriority='high' to ngOptimizedImage preloads to so their priority matches the priority of the image element itself PR Close #48010
This was referenced Nov 11, 2022
Merged
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…48010) Add fetchpriority='high' to ngOptimizedImage preloads to so their priority matches the priority of the image element itself PR Close angular#48010
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds
fetchpriority="high"to the preload link elements created by NgOptimizedImage. This is a necessary bugfix because without it, thefetchpriorityon the preload link doesn't match thefetchpriorityon the image element, which could cause the preload to actually lower the image download prioritization, which is the opposite of what we want to occur.This PR also adds a related line to the documentation, which was originally missing. CC: @AndrewKushnir @pkozlowski-opensource @kara