Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): Warn on fill ngOptimizedImage without height #48036

Closed
wants to merge 2 commits into from
Closed

fix(common): Warn on fill ngOptimizedImage without height #48036

wants to merge 2 commits into from

Commits on Nov 11, 2022

  1. fix(common): Warn on fill ngOptimizedImage without height 

    Add a warning if a fill-mode image is rendered without height. This is a common occurence if the user doesn't properly set the 'position' attribute of the parent element.
    @atcastle
    atcastle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0c0f6ff View commit details
    Browse the repository at this point in the history

  2. test(common): add e2e tests for the fill mode checks in the NgOptimiz… 

    …edImage directive

This commit adds extra e2e tests for the fill mode checks in the NgOptimizedImage directive to make
sure a warning is logged in a console.
    @AndrewKushnir
    AndrewKushnir committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f228fb2 View commit details
    Browse the repository at this point in the history