fix(router): Correct type of nextState parameter in canDeactivate

[JeanMeche]

Correct type of nextState parameter in canDeactivate guard to indicate it's never undefined

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

on canDeactivate(), nextState is always provided, there was no need to make it an optional parameter.

Issue Number: #47153

Does this PR introduce a breaking change?

• Yes
• No

[atscott]

I would consider this a fix rather than a refactor. So the commit message should read "fix(router): correct type of nextState parameter in canDeactivate guard to indicate it's never undefined".

I'm not sure if we need to consider this a breaking change, but I would expect that we do. I would bet there are tests for guards which manually pass in mocks for the parameter values that would break due to this change.

[JeanMeche]

@atscott fix is fine for me.

About the breaking changes, this PR breaks the internal tests, so yeah it's breaking something.

[AndrewKushnir]

@JeanMeche thanks for the PR, I've left a couple minor comments. It'd be great to remove any unrelated changes (removals of new lines, adding semicolons, etc) from this PR, so that it only contains the changes that are needed. You can create a followup PR if there are some formatting changes that you'd like to propose. Thank you.

[JeanMeche]

@AndrewKushnir done ✅

[atscott]

About the breaking changes, this PR breaks the internal tests, so yeah it's breaking something.

It looks like I was wrong about it being a breaking change. We can do this and implementors can still have nextState?: RouterStateSnapshot and it'll pass the build. So this looks like a safe change to make.

[JeanMeche]

@atscott I push the changes for CanDeactivateFn ☑

[atscott]

reviewed-for: public-api

[AndrewKushnir]

Reviewed-for: public-api

[dylhunn]

This PR was merged into the repository by commit b51929a.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}