Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): export the IMAGE_CONFIG token #48051

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The token introduced in 4fde292 was not exported publicly.

What is the new behavior?

It is exported publicly

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The token introduced in 4fde292 was not exported publicly.
@jessicajaniuk jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Nov 14, 2022
@ngbot ngbot bot added this to the Backlog milestone Nov 14, 2022
@jessicajaniuk jessicajaniuk requested review from AndrewKushnir and removed request for jessicajaniuk November 14, 2022 18:17
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cexbrayat thanks for catching this 👍

@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate action: presubmit The PR is in need of a google3 presubmit labels Nov 14, 2022
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir removed the request for review from dylhunn November 14, 2022 18:38
@AndrewKushnir
Copy link
Contributor

Presubmit.

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 14, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 804b855.

jessicajaniuk pushed a commit that referenced this pull request Nov 14, 2022
The token introduced in 4fde292 was not exported publicly.

PR Close #48051
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
The token introduced in 4fde292 was not exported publicly.

PR Close angular#48051
RGunning pushed a commit to RGunning/angular that referenced this pull request Apr 13, 2023
The token introduced in 4fde292 was not exported publicly.

PR Close angular#48051
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants