Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): accept inheriting the constructor from a class in … #48156

Closed
wants to merge 1 commit into from

Commits on Nov 21, 2022

  1. fix(compiler-cli): accept inheriting the constructor from a class in …

    …a library
    
    The stricter checks under `strictInjectionParameters` in Angular 15 now enforce that
    an inherited constructor must be compatible with DI, based on whether all parameters
    are valid injection tokens. There is an issue when the constructor is inherited from
    a class in a declaration file though, as information on the usage of `@Inject()` is
    not present within a declaration file. This means that this stricter check cannot be
    accurately performed, resulting in false positives.
    
    This commit disables the stricter check to behave the same as it did prior to
    Angular 15, therefore avoiding the false positive.
    
    Fixes angular#48152
    JoostK committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    f7a610d View commit details
    Browse the repository at this point in the history