Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(language-service): make selector nullable #48193

Closed
wants to merge 1 commit into from
Closed

refactor(language-service): make selector nullable #48193

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

This is a follow-up from #48147. Changes the DirectiveSymbol.selector to be nullable since it's possible to have directives without a selector.

@crisbeto
refactor(language-service): make selector nullable
0e2004b 
This is a follow-up from angular#48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Nov 23, 2022
@ngbot ngbot bot added this to the Backlog milestone Nov 23, 2022
@crisbeto crisbeto marked this pull request as ready for review November 23, 2022 09:53
@pullapprove pullapprove bot requested a review from alxhub November 23, 2022 09:53
@crisbeto crisbeto removed the request for review from alxhub November 23, 2022 09:53
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 23, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Nov 23, 2022

This PR was merged into the repository by commit 0138d75.

dylhunn pushed a commit that referenced this pull request Nov 23, 2022
@crisbeto @dylhunn
refactor(language-service): make selector nullable (#48193)
665d465 
This is a follow-up from #48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector.

PR Close #48193
@dylhunn dylhunn closed this in 0138d75 Nov 23, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 24, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@crisbeto @trekladyone
refactor(language-service): make selector nullable (angular#48193)
f33b555 
This is a follow-up from angular#48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector.

PR Close angular#48193
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @dylhunn @atscott