Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): unable to inject ChangeDetectorRef inside host directives #48355

Closed
wants to merge 1 commit into from
Closed

fix(core): unable to inject ChangeDetectorRef inside host directives #48355

wants to merge 1 commit into from

Commits on Dec 5, 2022

  1. fix(core): unable to inject ChangeDetectorRef inside host directives 

    When injecting the `ChangeDetectorRef` into a node that matches a component, we create a new ref using the component's LView. This breaks down for host directives, because they run before the component's LView has been created.

These changes resolve the issue by creating the LView before creating the node injector for the directives.

Fixes angular#48249.
    @crisbeto
    crisbeto committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1b37f46 View commit details
    Browse the repository at this point in the history