-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Drop public factories
property for IterableDiffers
#49598
Conversation
e7c1613
to
7e8200a
Compare
@JeanMeche While I don't expect anyone to really be using this, can you still add the "breaking change" footer to this commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: fw-core, public-api
@JeanMeche Looks like this might need a rebase? If it's otherwise ready to go, please @ me once rebased, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
…Breaking change The `factories` property was marked as deprecated in v4 to make it private. Let's move it to private.
Remove some `any` and use the non-deprecated `Injector.create` overload.
7e8200a
to
cc13542
Compare
@dylhunn Done ! |
This PR was merged into the repository by commit 1aef29c. |
Remove some `any` and use the non-deprecated `Injector.create` overload. PR Close #49598
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removing the public from
IterableDiffers
'sfactories
which was deprecated long time ago. Also there is a quick cleanup of the related tests.Let me know if the breaking change requires some work.
Does this PR introduce a breaking change?