Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform-server): rename provideServerSupport to provideServerRendering #49678

Closed
wants to merge 1 commit into from
Closed

feat(platform-server): rename provideServerSupport to provideServerRendering #49678

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

This commit renames provideServerSupport to provideServerRendering.

@alan-agius4
feat(platform-server): rename provideServerSupport to `provideServe…
4f077b2 
…rRendering`

This commit renames `provideServerSupport` to `provideServerRendering`.
@alan-agius4 alan-agius4 added area: server Issues related to server-side rendering target: major This PR is targeted for the next major release labels Apr 3, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 3, 2023
@alan-agius4 alan-agius4 marked this pull request as ready for review April 3, 2023 15:05
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 3, 2023
@pullapprove pullapprove bot requested review from alxhub, atscott and dylhunn April 3, 2023 15:05
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 3, 2023
@alan-agius4 alan-agius4 modified the milestones: Backlog, v16-candidates Apr 3, 2023
@pullapprove pullapprove bot requested review from atscott and dylhunn April 3, 2023 15:21
atscott
atscott approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from jessicajaniuk April 3, 2023 16:01
jessicajaniuk
jessicajaniuk approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-platform-server, public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2023
@angular angular deleted a comment from ngbot bot Apr 3, 2023
AndrewKushnir
AndrewKushnir approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dylhunn
Copy link
Contributor

dylhunn commented Apr 3, 2023

This PR was merged into the repository by commit 7870fb0.

@dylhunn dylhunn closed this in 7870fb0 Apr 3, 2023
@alan-agius4 alan-agius4 deleted the provideServerRendering branch April 4, 2023 04:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v16-candidates
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alan-agius4 @dylhunn @atscott @AndrewKushnir @jessicajaniuk