Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(platform-browser): remove deprecated BrowserTransferStateModule symbol #49718

Closed
wants to merge 1 commit into from
Closed

refactor(platform-browser): remove deprecated BrowserTransferStateModule symbol #49718

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

The TransferState class was updated in v14 in a way that the BrowserTransferStateModule was no longer required. The BrowserTransferStateModule was deprecated in v14.1 and it's currently empty. This commit removes the BrowserTransferStateModule.

BREAKING CHANGE: The deprecated BrowserTransferStateModule was removed, since it's no longer needed. The TransferState class can be injected without providing the module. The BrowserTransferStateModule was empty starting from v14 and you can just remove the reference to that module from your applications.

PR Type

What kind of change does this PR introduce?

  • Refactoring

Does this PR introduce a breaking change?

  • Yes, the BrowserTransferStateModule was removed as no longer needed, see commit description.
  • No

@JeanMeche @AndrewKushnir
refactor(platform-browser): remove deprecated `BrowserTransferStateMo…
8ff5dc7 
…dule` symbol

The `TransferState` class was updated in v14 in a way that the `BrowserTransferStateModule` was no longer required. The `BrowserTransferStateModule` was deprecated in v14.1 and it's currently empty. This commit removes the `BrowserTransferStateModule`.

BREAKING CHANGE: The deprecated `BrowserTransferStateModule` was removed, since it's no longer needed. The `TransferState` class can be injected without providing the module. The `BrowserTransferStateModule` was empty starting from v14 and you can just remove the reference to that module from your applications.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer breaking changes area: server Issues related to server-side rendering target: major This PR is targeted for the next major release flag: breaking change labels Apr 5, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 5, 2023
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 5, 2023
atscott
atscott approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from dylhunn April 5, 2023 18:35
dylhunn
dylhunn approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, public-api

@AndrewKushnir
Copy link
Contributor Author

Important note: this is a cherry-picked commit from PR that @JeanMeche created: #49674. The reason for extracting this commit is that we want to avoid extra complexity of having a schematic, since the migration is trivial (just drop the module reference) and since the module was deprecated 2 major version ago, we expect that a lot of apps already removed this symbol anyway.

@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v16-candidates Apr 5, 2023
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 5, 2023
alan-agius4
alan-agius4 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylhunn
Copy link
Contributor

dylhunn commented Apr 5, 2023 •
edited

@AndrewKushnir Do we want to merge this into v16 today? (since it's a breaking)

@AndrewKushnir AndrewKushnir mentioned this pull request Apr 5, 2023
Closed
2 tasks
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir
Copy link
Contributor Author

@dylhunn yeah, it'd be great to land it before the release today. Running a presubmit now (though it should mostly be a noop since there are no references to the BrowserTransferStateModule symbol in g3).

@dylhunn
Copy link
Contributor

dylhunn commented Apr 5, 2023

Presubmit looks good.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Apr 5, 2023
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Apr 5, 2023 •
edited

Caretaker note: presubmit looks good, this PR is ready for merge. // cc @dylhunn

@dylhunn
Copy link
Contributor

dylhunn commented Apr 5, 2023

This PR was merged into the repository by commit 9bd9a11.

@dylhunn dylhunn closed this in 9bd9a11 Apr 5, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

1 similar comment
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@dylhunn dylhunn dylhunn approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering breaking changes detected: breaking change PR contains a commit with a breaking change flag: breaking change merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v16-candidates
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndrewKushnir @dylhunn @atscott @alan-agius4 @JeanMeche