Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone.js): patch entire promise in node #50552

Closed
wants to merge 1 commit into from
Closed

fix(zone.js): patch entire promise in node #50552

wants to merge 1 commit into from

Commits on Jun 2, 2023

  1. fix(zone.js): patch entire promise in node 

    In angular#49144 we introduced a change to only path `Promise.prototype.then` due to Node.js `SafePromise` complaining about `Promise.prototype.then` called on incompatible receiver. This however introduced a number of regressions. This commit reverts this change and re-introduces the changes to patch the entire promise on Node.

The original `SafePromise` problem is no longer reproducible as of Node.js version 18.13+ as it was addressed as part of nodejs/node#45175.

While the Angular CLI does not yet generate ESM server bundles, users using ESM with dynamic imports will require using Node.js 18.13 or later.

Closes angular#50513, closes angular#50457, closes angular#50414 and closes angular#49930
    @alan-agius4
    alan-agius4 committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    88bb6e8 View commit details
    Browse the repository at this point in the history