-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http): check whether Zone
is defined
#51119
Conversation
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arturovt thanks for the improvement!
This PR was merged into the repository by commit 57e8412. |
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close #51119
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close angular#51119
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close angular#51119
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close angular#51119
Accessing the
Zone
variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where thedoRequest
is being called.