Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

50736 cleanup #51148

Closed
wants to merge 2 commits into from
Closed

50736 cleanup #51148

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Jul 24, 2023 •
edited

Part of #15360

@HyperLife1119 @pkozlowski-opensource
feat(common): add component input binding support for NgComponentOutlet
78c85a0 
This commit add component input binding support for NgComponentOutlet.
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jul 24, 2023
@pkozlowski-opensource
Copy link
Member Author

This is a version of #50736 that passes g3 tests (alongside with other minor cleanups).

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Jul 24, 2023
Closed
14 tasks
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: minor This PR is targeted for the next minor release labels Jul 24, 2023
@ngbot ngbot bot added this to the Backlog milestone Jul 24, 2023
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review July 24, 2023 12:20
AndrewKushnir
AndrewKushnir approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkozlowski-opensource LGTM, just a couple non-blocking comments.

packages/common/src/directives/ng_component_outlet.ts Outdated Show resolved Hide resolved
packages/common/src/directives/ng_component_outlet.ts Show resolved Hide resolved
@pullapprove pullapprove bot requested a review from AndrewKushnir July 24, 2023 19:11
dylhunn
dylhunn approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-common, public-api

@pullapprove pullapprove bot requested a review from jessicajaniuk July 24, 2023 20:35
AndrewKushnir
AndrewKushnir approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 25, 2023
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 29d3581.

@JeanMeche JeanMeche mentioned this pull request Jul 25, 2023
Closed
1 task
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 25, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
496f4fc 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
sunilbaba pushed a commit to sunilbaba/angular that referenced this pull request Jul 26, 2023
@HyperLife1119 @sunilbaba
feat(common): add component input binding support for NgComponentOutl…
b27d1db 
…et (angular#51148)

This commit add component input binding support for NgComponentOutlet.

PR Close angular#51148
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 26, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
57935bf 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 26, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
d8e65b4 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 26, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
cb57289 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 26, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
ad35c8d 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 27, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
d0d6a62 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 27, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
45b64bf 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 27, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
833b9f4 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 27, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
bb24e19 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Jul 28, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
3b850c7 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Aug 4, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
8af2ce1 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Aug 4, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
7da4d0f 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Aug 6, 2023
@JeanMeche
docs: update Dynamic Component loader docs to rely on `ngComponentOut…
b88ba53 
…let`

With angular#51148, the `ngComponentOutlet` directive now supports inputs.
This allows a less verbose and simpler API to instantiate components dynamicaly.

Fixes angular#49875
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@HyperLife1119
feat(common): add component input binding support for NgComponentOutl…
8f3ffc0 
…et (angular#51148)

This commit add component input binding support for NgComponentOutlet.

PR Close angular#51148
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@HyperLife1119 @ChellappanRajan
feat(common): add component input binding support for NgComponentOutl…
a6edeb5 
…et (angular#51148)

This commit add component input binding support for NgComponentOutlet.

PR Close angular#51148
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
v16.2 candidates
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkozlowski-opensource @AndrewKushnir @dylhunn @HyperLife1119