feat(router): Allow onSameUrlNavigation: 'ignore' in navigateByUrl
#52265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`.
atscott
added
feature
pullapprove
bot
requested review from
alxhub,
AndrewKushnir and
pkozlowski-opensource
AndrewKushnir
approved these changes
Oct 18, 2023
atscott
requested review from
jessicajaniuk
and removed request for
pkozlowski-opensource,
alxhub and
dylhunn
jessicajaniuk
approved these changes
Nov 13, 2023
jessicajaniuk
added
the
merge: caretaker note
|
Caretaker: can't remove unneeded reviewers. Safe to merge. |
|
This PR was merged into the repository by commit 726530a. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be
ignoreinstead. This commit allowsonSameUrlNavigationin therouter.navigateByUrlto beignorewhere it was previously restricted to onlyreload.